refactor(api): move machine controller to separate crate#1964
Open
poroh wants to merge 2 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
poroh
force-pushed
the
machine-controller-crate
branch
from
e748795 to
4820a2b
Compare
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
Move Scout firmware upgrade payload messages into a small dedicated proto and use that generated code from the machine controller instead of depending on the full RPC crate. This keeps the machine controller’s RPC usage limited to JSON serialization of firmware upgrade tasks and reduces coupling while preserving the existing ForgeAgentControl wire shape. Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
poroh
force-pushed
the
machine-controller-crate
branch
from
d9fb3b1 to
f3b0b50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is final PR of moving out machine state controller to separate crate.
It contains two comits:
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes