agent: Avoid needlessly re-applying an unchanged NVUE configuration#1965
Open
DrewBloechl wants to merge 2 commits into
Open
agent: Avoid needlessly re-applying an unchanged NVUE configuration#1965DrewBloechl wants to merge 2 commits into
DrewBloechl wants to merge 2 commits into
Conversation
chet
reviewed
May 27, 2026
| &mut self, | ||
| config: &NvueConfig, | ||
| ) -> Result<Option<String>, NvueClientError> { | ||
| let new_hash = config.u64_hash(); |
Contributor
There was a problem hiding this comment.
Should we instead lean on the ConfigVersion that we got from carbide-api for the config? i.e. if the ConfigVersion hasn't changed, don't write anything?
Contributor
Author
There was a problem hiding this comment.
We don't currently have a way to link a given NVUE config back to the ConfigVersion it relates to, so while I'd like to do that at some point, it seems awkward under the current architecture.
Contributor
Author
There was a problem hiding this comment.
I suppose we could do that further up in the logic, but this is more or less mirroring what the HBN startup-file code does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The agent's main loop is supposed to distinguish between the case where the specified network configuration is the same as it was before (in which case we can avoid needless work trying to apply it again), versus the case where the configuration is actually different. This wasn't implemented for the NVUE REST client code.
This adds a hash comparison to the NVUE REST implementation so that we don't create a bunch of churn in NVUE configuration revisions.
closes #1925
Type of Change
Related Issues (Optional)
#1925
Breaking Changes
Testing
Additional Notes