Skip to content

chore(api): drop gating from the allow_zero_dpu_hosts flag #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(api): drop gating from the allow_zero_dpu_hosts flag #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 112 additions & 46 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/api-test-helper/src/api_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ pub async fn start(
explorations_per_run = 90
create_machines = true
machines_created_per_run = 30
allow_zero_dpu_hosts = true
allow_proxy_to_unknown_host = false
{bmc_proxy_cfg}
reset_rate_limit = "3600s"
Expand Down
1 change: 0 additions & 1 deletion crates/api/src/cfg/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ applicable.
| `rotate_switch_nvos_credentials` | `bool` | `false` | Auto-rotate switch NVOS admin credentials. |
| `override_target_ip` | `Option<String>` | — | **Deprecated.** Use `bmc_proxy`. Debug BMC IP override. |
| `override_target_port` | `Option<u16>` | — | **Deprecated.** Use `bmc_proxy`. Debug BMC port override. |
| `allow_zero_dpu_hosts` | `bool` | `false` | Allow hosts with zero DPUs (set `false` in prod). |
| `bmc_proxy` | `HostPortPair` | — | BMC proxy host:port for integration testing/dev. |
| `allow_changing_bmc_proxy` | `Option<bool>` | *(auto)* | Allow runtime changes to `bmc_proxy`. Auto-detected from initial config. |
| `reset_rate_limit` | `Duration` | `1h` | Minimum time between SiteExplorer-initiated BMC resets. |
Expand Down
4 changes: 0 additions & 4 deletions crates/api/src/cfg/file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,6 @@ impl CarbideConfig {
spdm_enabled: self.spdm.enabled,

dpu_enable_secure_boot: self.dpu_config.dpu_enable_secure_boot,
allow_zero_dpu_hosts: self.site_explorer.allow_zero_dpu_hosts,
}
}
}
Expand Down Expand Up @@ -2673,7 +2672,6 @@ mod tests {
machines_created_per_run: 1,
override_target_ip: None,
override_target_port: None,
allow_zero_dpu_hosts: false,
bmc_proxy: carbide_site_explorer::config::bmc_proxy(None),
allow_changing_bmc_proxy: None,
reset_rate_limit: Duration::hours(1),
Expand Down Expand Up @@ -2847,7 +2845,6 @@ mod tests {
machines_created_per_run: 2,
override_target_ip: Some("1.2.3.4".to_owned()),
override_target_port: Some(10443),
allow_zero_dpu_hosts: false,
bmc_proxy: carbide_site_explorer::config::bmc_proxy(None),
allow_changing_bmc_proxy: None,
reset_rate_limit: Duration::hours(2),
Expand Down Expand Up @@ -3156,7 +3153,6 @@ mod tests {
machines_created_per_run: 2,
override_target_ip: Some("1.2.3.4".to_owned()),
override_target_port: Some(10443),
allow_zero_dpu_hosts: false,
bmc_proxy: carbide_site_explorer::config::bmc_proxy(None),
allow_changing_bmc_proxy: None,
reset_rate_limit: Duration::hours(2),
Expand Down
1 change: 0 additions & 1 deletion crates/api/src/state_controller/machine/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,4 @@ pub struct MachineStateHandlerSiteConfig {
pub spdm_enabled: bool,

pub dpu_enable_secure_boot: bool,
pub allow_zero_dpu_hosts: bool,
}
Loading
Loading