Prevent duplicate GPU registration for health checks - #2053
Closed
aryangorwade wants to merge 4 commits into
Closed
aryangorwade wants to merge 4 commits into
aryangorwade wants to merge 4 commits into
Conversation
Signed-off-by: tryuuu <ryu23210@gmail.com>
Signed-off-by: tryuuu <ryu23210@gmail.com>
Signed-off-by: tryuuu <ryu23210@gmail.com>
Signed-off-by: Aryan Gorwade <agorwade@nvidia.com>
copy-pr-bot
Bot
force-pushed
the
pull-request/1930
branch
from
September 22, 2026 02:47
59ea5f1 to
615269e
Compare
Contributor
|
@aryangorwade I am not sure why this was closed. |
Author
|
@tariq1890 Probably because it referenced #1930 which was then merged. I duplicated this in #2054. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes redundant GPU health registration calls that can happen when multiple
Deviceobjects share the same parent GPU. It builds on changes made in #1930 and should be merged in afterwards.Closes #2052 .
Checklist
make lint)make test)make check-modules)make check-third-party-notices)Testing
Verified via manual testing on a GPU node. Scenarios tested include unshared GPUs, time-sliced & MPS shared GPUs, multiple MIG instances and time-sliced MIG & mixed MIG. Plugin restart/config reload behavior was also tested.