Cherry-pick fix for unreachable condition issue from upstream numba #886
Open
acosmicflamingo wants to merge 6 commits into
Open
Cherry-pick fix for unreachable condition issue from upstream numba #886acosmicflamingo wants to merge 6 commits into
acosmicflamingo wants to merge 6 commits into
Conversation
As title
As title
This syntax choice is like what the upstream cpython does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #879
A couple of months ago, this same issue appeared in upstream numba: numba/numba#10319. They fixed it in this PR, so all that's needed is to just cherry-pick their fixes. I verified that the reproducer @shwina created for us does work with these changes.
Only question I have is whether
numba/tests/test_nested_calls.pyhas any place in numba-cuda. I deliberately didn't cherry-pick numba/numba@b6a2a10 because I figure this repository is meant for CUDA-specific functionality and it's upstream's responsibility for ensuring this kind of functionality is tested. If my assumption is correct, then this PR is ready to be merged.If it is needed, I wonder where it should be placed because numba/tests directory doesn't exist. I'm 99% sure it's not needed but just want an opinion from someone with authority ;)