fix: disable chmod hook - #1942
Merged
Merged
Conversation
rajatchopra
marked this pull request as draft
July 14, 2026 15:55
rajatchopra
force-pushed
the
disablechmod
branch
2 times, most recently
from
July 15, 2026 17:55
6015ddc to
d60cdf6
Compare
rajatchopra
marked this pull request as ready for review
July 16, 2026 14:45
cdesiniotis
reviewed
Sep 3, 2026
cdesiniotis
left a comment
cdesiniotis
left a comment
Contributor
There was a problem hiding this comment.
Since this hook has been deprecated and off by default (since the 1.18.0 release, see commit), I think the next step would be to remove it entirely (instead of adding extra logic to prevent one from enabling it).
| command := ConfigureCDIHookCommand(&logger.NullLogger{}, &cli.Command{}) | ||
|
|
||
| require.Nil(t, command.Command("chmod")) | ||
| require.NotNil(t, command.Command("create-symlinks")) |
Contributor
There was a problem hiding this comment.
Question -- Is this returning an error because the create-symlinks hook fails in this context (e.g. the right set of arguments are not provided)?
rajatchopra
force-pushed
the
disablechmod
branch
from
September 3, 2026 20:23
d60cdf6 to
6d882b4
Compare
Coverage Report for CI Build 34900314396Coverage increased (+0.03%) to 44.122%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
rajatchopra
force-pushed
the
disablechmod
branch
from
September 3, 2026 20:28
6d882b4 to
0ef8ed4
Compare
cdesiniotis
reviewed
Sep 11, 2026
rajatchopra
force-pushed
the
disablechmod
branch
from
September 14, 2026 21:42
0ef8ed4 to
6254f91
Compare
henry118
reviewed
Sep 15, 2026
- Deleted the nvidia-cdi-hook chmod implementation. - Deleted the device-folder-permissions workaround that emitted chmod hooks. - Kept the unsupported-command behavior, so legacy CDI specs invoking chmod still warn and don’t block startup. - Suitably modified the unit tests Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
rajatchopra
force-pushed
the
disablechmod
branch
from
September 16, 2026 22:10
6254f91 to
ec4085b
Compare
henry118
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chmod hook was deprecated earlier. We can disable it now. Any code requiring correct access to /dev/dri does not need this backward compatible hook as crun has a fix now. For more details, see #1221
Existing CDI specs invoking chmod will now use the unsupported-hook handler: they emit a warning, perform no chmod, and do not prevent container startup.