Adding missing cdi-hooks in readme - #1998
Merged
Merged
Conversation
Coverage Report for CI Build 31850129937Coverage remained the same at 43.626%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
tariq1890
reviewed
Aug 14, 2026
Contributor
|
nit: Can we order the hook names lexically? |
Member
Author
tbh, I don't think it's necessary. And it would require even more effort to make changes in the future. |
tariq1890
approved these changes
Aug 16, 2026
cdesiniotis
reviewed
Aug 17, 2026
| * `chmod` - Change the permissions of a file or directory inside the directory path to be mounted into a container. | ||
| * `create-symlinks` - Create symlinks inside the directory path to be mounted into a container. | ||
| * `update-ldcache` - Update the dynamic linker cache inside the directory path to be mounted into a container. | ||
| * `enable-cuda-compat` - Ensure that the directory containing the CUDA compat libraries is added to the ldconfig search path. |
Contributor
There was a problem hiding this comment.
Suggested change
| * `enable-cuda-compat` - Ensure that the directory containing the CUDA compat libraries is added to the ldconfig search path. | |
| * `enable-cuda-compat` - Ensure that the directory containing the CUDA compat libraries is added to the ldconfig search path if required. |
Signed-off-by: Henry Wang <henrwang@nvidia.com>
cdesiniotis
approved these changes
Aug 17, 2026
Contributor
|
/cherry-pick release-1.20 |
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the newly added hooks into the readme file.