Skip to content

[release-1.20] feat: add new CDI hook to set CUDA memory limits - #2091

Closed
github-actions[bot] wants to merge 1 commit into
release-1.20from
backport-2075-to-release-1.20
Closed

github-actions[bot] wants to merge 1 commit into
release-1.20from
backport-2075-to-release-1.20

Conversation

@github-actions

Copy link
Copy Markdown

🤖 Automated backport of #2075 to release-1.20

⚠️ This PR has merge conflicts that need manual resolution.

Original PR: #2075
Original Author: @tariq1890

Cherry-picked commits (1):

  • 2d76167 feat: add new CDI hook to set CUDA memory limits

Next Steps:

  1. Review the conflicts in the "Files changed" tab
  2. Check out this branch locally: git fetch origin backport-2075-to-release-1.20 && git checkout backport-2075-to-release-1.20
  3. Resolve conflicts manually
  4. Push the resolution: git push --force-with-lease origin backport-2075-to-release-1.20

Instructions for resolving conflicts
git fetch origin backport-2075-to-release-1.20
git checkout backport-2075-to-release-1.20
# Resolve conflicts in your editor
git add .
git commit
git push --force-with-lease origin backport-2075-to-release-1.20

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>

get cgroup path from procfs instead

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
(cherry picked from commit 2d76167)
@copy-pr-bot

copy-pr-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 34873868983

Coverage decreased (-0.2%) to 43.824%

Details

  • Coverage decreased (-0.2%) from the base build.
  • Patch coverage: 123 uncovered changes across 6 files (39 of 162 lines covered, 24.07%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
cmd/nvidia-cdi-hook/apply-cuda-memory-limits/apply-cuda-memory-limits.go 116 8 6.9%
internal/discover/hooks.go 5 0 0.0%
internal/info/cgroup/cgroup_path.go 16 11 68.75%
pkg/nvcdi/cuda-memory-limits.go 19 17 89.47%
pkg/nvcdi/full-gpu-nvml.go 5 3 60.0%
cmd/nvidia-cdi-hook/commands/commands.go 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13691
Covered Lines: 6000
Line Coverage: 43.82%
Coverage Strength: 0.44 hits per line

💛 - Coveralls

@tariq1890

Copy link
Copy Markdown
Contributor

Closing this one. I'll trigger a cherry-pick PR after this PR is merged.

@tariq1890 tariq1890 closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants