-
Notifications
You must be signed in to change notification settings - Fork 38
Add Spark-based data generation for K8s (replaces MapReduce) #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wjxiz1992
wants to merge
7
commits into
NVIDIA:dev
Choose a base branch
from
wjxiz1992:data-gen-k8s
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bb496fc
init support for k8s data gen
wjxiz1992 ae55e43
add hdfs related readme
wjxiz1992 0cf1830
resolve comments
wjxiz1992 7a520eb
Fix PR review comments for Spark-based data generation
wjxiz1992 d8b1864
Add K8s Dockerfiles and update data generation docs
wjxiz1992 ede7d6d
Address remaining PR #248 review comments
wjxiz1992 3160717
Fix py4j symlink error handling and document Dockerfile.spark-k8s
wjxiz1992 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Base image must be built first from your Spark distribution: | ||
| # cd $SPARK_HOME && ./bin/docker-image-tool.sh -t <tag> \ | ||
| # -p kubernetes/dockerfiles/spark/bindings/python/Dockerfile build | ||
| # Then update the FROM line below to match your image name and tag. | ||
| ARG BASE_IMAGE=spark-py:spark-3.5.6 | ||
| FROM ${BASE_IMAGE} | ||
|
|
||
| USER root | ||
|
|
||
| COPY nds_gen_data_spark.py /opt/spark/work-dir/ | ||
| COPY tpcds-gen/target/lib/dsdgen.tar.gz /opt/spark/work-dir/ | ||
|
|
||
| USER ${spark_uid} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Standalone Spark + PySpark image for K8s deployment. | ||
| # Builds a complete Spark image from a Spark distribution directory. | ||
| # Build context must be $SPARK_HOME (the unpacked Spark distribution). | ||
| # | ||
| # Usage: | ||
| # cd $SPARK_HOME | ||
| # docker build -f <repo>/nds/Dockerfile.spark-k8s -t spark-custom:<tag> . | ||
| # | ||
| # For a simpler setup, use Dockerfile.k8s-test instead, which layers on top | ||
| # of the official pre-built Spark Python image. | ||
| FROM ubuntu:24.04 | ||
|
|
||
| ARG spark_uid=185 | ||
|
|
||
| # Install Java 17 + Python 3.12 (default on 24.04) | ||
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends \ | ||
| openjdk-17-jre-headless \ | ||
| python3 \ | ||
| python3-pip \ | ||
| tini \ | ||
| procps \ | ||
| && rm -rf /var/cache/apt/* /var/lib/apt/lists/* | ||
|
|
||
| # Set up Spark directory structure | ||
| ENV SPARK_HOME=/opt/spark | ||
| ENV PATH="${SPARK_HOME}/bin:${PATH}" | ||
| ENV PYTHONPATH="${SPARK_HOME}/python:${SPARK_HOME}/python/lib/py4j-src.zip" | ||
|
|
||
| # Copy Spark distribution | ||
| COPY jars ${SPARK_HOME}/jars | ||
| COPY bin ${SPARK_HOME}/bin | ||
| COPY sbin ${SPARK_HOME}/sbin | ||
| COPY python ${SPARK_HOME}/python | ||
| COPY kubernetes/dockerfiles/spark/entrypoint.sh /opt/ | ||
| COPY kubernetes/dockerfiles/spark/decom.sh /opt/ | ||
|
|
||
| RUN chmod +x /opt/entrypoint.sh /opt/decom.sh && \ | ||
| mkdir -p ${SPARK_HOME}/work-dir && \ | ||
| chmod g+w ${SPARK_HOME}/work-dir && \ | ||
| # Create a stable symlink so PYTHONPATH works across py4j versions | ||
| PY4J_ZIP=$(ls ${SPARK_HOME}/python/lib/py4j-*-src.zip 2>/dev/null | head -1) && \ | ||
| [ -n "$PY4J_ZIP" ] || { echo "ERROR: no py4j-*-src.zip found in ${SPARK_HOME}/python/lib/"; exit 1; } && \ | ||
| ln -sf "$PY4J_ZIP" ${SPARK_HOME}/python/lib/py4j-src.zip && \ | ||
| # Create spark user | ||
| useradd -u ${spark_uid} -r -g root -d ${SPARK_HOME} -s /sbin/nologin spark | ||
|
|
||
| WORKDIR ${SPARK_HOME}/work-dir | ||
|
|
||
| ENTRYPOINT [ "/opt/entrypoint.sh" ] | ||
|
|
||
| USER ${spark_uid} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| # Template for Spark-based TPC-DS data generation (nds_gen_data_spark.py). | ||
| # This replaces the Hadoop MapReduce approach and works on YARN, K8s, or Standalone. | ||
| # | ||
| # Usage: | ||
| # ./spark-submit-template datagen_submit.template \ | ||
| # nds_gen_data_spark.py 100 100 hdfs:///data/raw_sf100 --overwrite | ||
|
|
||
| source base.template | ||
|
|
||
| # Path to the dsdgen archive (built by: cd tpcds-gen && make, then tar czf) | ||
| export DSDGEN_ARCHIVE=${DSDGEN_ARCHIVE:-tpcds-gen/target/lib/dsdgen.tar.gz} | ||
|
|
||
| export SPARK_CONF=("--master" "${SPARK_MASTER}" | ||
| "--deploy-mode" "client" | ||
| "--conf" "spark.driver.memory=${DRIVER_MEMORY}" | ||
| "--conf" "spark.executor.cores=${EXECUTOR_CORES}" | ||
| "--conf" "spark.executor.instances=${NUM_EXECUTORS}" | ||
| "--conf" "spark.executor.memory=${EXECUTOR_MEMORY}" | ||
| "--archives" "${DSDGEN_ARCHIVE}#dsdgen") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.