Skip to content

Update check_main to true as default#58

Merged
pxLi merged 1 commit intoNVIDIA:mainfrom
pxLi:fix-57
Apr 14, 2026
Merged

Update check_main to true as default#58
pxLi merged 1 commit intoNVIDIA:mainfrom
pxLi:fix-57

Conversation

@pxLi
Copy link
Copy Markdown
Member

@pxLi pxLi commented Apr 14, 2026

Fixes #57

Changed check_main default from false to true so license header validation runs on all PRs, including those targeting the main branch. Previously these were skipped by default.

@pxLi pxLi requested a review from a team as a code owner April 14, 2026 01:42
Signed-off-by: Peixin Li <pxLi@nyu.edu>
@pxLi pxLi merged commit 4b21a5b into NVIDIA:main Apr 14, 2026
4 checks passed
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 14, 2026

Greptile Summary

This PR makes two changes to license-header-check/action.yml: it updates the copyright year from 2025 to 2026 (matching the current year), and flips the check_main input default from false to true so license-header validation now runs by default on PRs targeting the main branch.

Existing consumers of this action who rely on the implicit default (i.e., they do not explicitly pass check_main) will now have the check enabled for main-targeting PRs — a behavioral breaking change that is the stated intent of fixing #57.

Confidence Score: 5/5

Safe to merge — the change is intentional, minimal, and aligns exactly with the stated goal of fixing #57.

Both changes (copyright year and default value flip) are correct and intentional. No new logic is introduced, and the existing check logic handles the new default correctly. No P0/P1 issues found.

No files require special attention.

Important Files Changed

Filename Overview
license-header-check/action.yml Copyright year updated to 2026 and check_main default changed from false to true; intentional behavioral change, no logic errors introduced.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR triggered] --> B{check_main == false\nAND base.ref == main?}
    B -- Yes --> C[Skip check\nexit 0]
    B -- No --> D[Get changed files via git diff]
    D --> E[Filter by include/exclude patterns]
    E --> F{All files have\nvalid license header?}
    F -- Yes --> G[All files passed\nexit 0]
    F -- No --> H[Report missing headers\nexit 1]
Loading

Reviews (1): Last reviewed commit: "Update check_main to true as default" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] license header check ignores merge to main changes

5 participants