Force-reinstall maturin in portable top_of_tree dynamo source build#183
Merged
ishandhanani merged 1 commit intoMay 29, 2026
Merged
Conversation
The portable (non-SGLang) branch of the top_of_tree dynamo source install guarded maturin behind `command -v maturin` and ran a plain `pip install`. On images that ship the maturin module without a console script, the guard trips but pip reports 'already satisfied', so no binary is created and the later `maturin build` fails with 'maturin: command not found'. Match the hash and SGLang paths: drop the guard and force-reinstall maturin unconditionally. Add branch-pinned test assertions so the same regression is caught on all three source-install paths.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage ? 65.31%
=======================================
Files ? 67
Lines ? 8251
Branches ? 0
=======================================
Hits ? 5389
Misses ? 2862
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The portable (non-SGLang) branch of the
top_of_treedynamo source install guarded maturin behindcommand -v maturinand ran a plainpip install:On images that ship the
maturinPython module without a console script, the guard trips (command -v maturinfails) but pip reports "already satisfied" — so no binary is created and the latermaturin builddies withmaturin: command not found. Thehashand SGLang paths already avoid this with--force-reinstall; the portable branch was the only one missing it.Changes
schema.py— portable branch now force-reinstalls maturin unconditionally, matching the other two source-install paths:test_configs.py— branch-pinned assertions so the same regression is caught on all three paths (hash,top_of_treesglang,top_of_treeportable).Before / After
Generated
top_of_treeportable branch:bash -nconfirms the generated command still parses cleanly.Tests
The new portable assertion fails on the old code (proving it catches the bug) and passes after the fix:
Full suite with this PR — no tests broken: