Sync#20
Merged
Merged
Conversation
…rd to see when config missing keys, and to enable build names like `F-antibody-escape`
…es with substantial antibody escape
As pointed out by @jameshadfield [here](nextstrain#114 (comment)), the inclusion of this file as a target in `Snakefile` was causing errors when there is no *F-antibody-escape* build. Rather than the more complex solution he proposed, we can just remove this file as a target overall, as it will be built due to downstream dependencies when there is a *F-antibody-escape* build (as it is needed to make tree JSON), and is not needed otherwise. I believe with this change, [pull request nextstrain#114](nextstrain#114) should now pass continuous integration testing.
Remove metadata_with_scores CSV as Snakemake target
Fix bug that was introduced in nextstrain#112, where the filtering includes both OPEN and RESTRICTED records in outputs.
It's feasible that we run into a situation where none of the data from PPX is RESTRICTED, so guard against that by only warning on empty outputs.
Fix ingest filter of PPX data
Dms data for F
set display defaults for dms builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Updating upstream changes to fork
How to Test
✅ Checks
Screenshots (if applicable)