Fix: prevent widget getting stuck at #/all when navigating forecast dates
#932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition in
WidgetRouterHandlerthat caused the widget to get stuck at#/allduring zone-date-zone navigation. The issue occurred whenuseHash'ssetTimeout-delayed state captured intermediate widget routing states instead of the final hash value we wantedRelated Issues
Fixes #918
Key Changes
WidgetRouterHandler.client.tsx:
window.location.hashdirectly instead of usingobservedHashstateobservedHashstill triggers the effect when hash changes, but we always read the current hash valueHow to test
/forecasts/avalanche/olympics)#/allwhile URL showed correct placeAlso test:
Screenshots / Demo video
https://www.loom.com/share/d0b89b8ff5774699b0e5294381742ffe