Skip to content

Add opt-in allow_macos_failure input to test_nwx_cmake_build/test_nwx_pip_build #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmrichard merged 1 commit into from
Aug 10, 2026
Merged

Add opt-in allow_macos_failure input to test_nwx_cmake_build/test_nwx_pip_build #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/test_nwx_cmake_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,17 @@ on:
type: string
required: false
default: ""
allow_macos_failure:
description: >-
If "true", a failure on the macos-14 matrix leg is reported but
does not fail the job/block the workflow (via continue-on-error).
Other legs are unaffected. For repos with a known, tracked,
macOS-only issue that shouldn't block merges while it's being
investigated -- default "false" keeps the normal all-legs-required
behavior for every other caller.
type: string
required: false
default: "false"

jobs:
platform_matrix:
Expand All @@ -57,6 +68,7 @@ jobs:
matrix:
include: ${{ fromJSON(needs.platform_matrix.outputs.dev_matrix) }}
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.os == 'macos-14' && inputs.allow_macos_failure == 'true' }}
steps:
- name: Checkout Source
uses: actions/checkout@v4
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/test_nwx_pip_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@ on:
type: string
required: false
default: ""
allow_macos_failure:
description: >-
If "true", a failure on the macos-14 matrix leg is reported but
does not fail the job/block the workflow (via continue-on-error).
Other legs are unaffected. For repos with a known, tracked,
macOS-only issue that shouldn't block merges while it's being
investigated -- default "false" keeps the normal all-legs-required
behavior for every other caller.
type: string
required: false
default: "false"

jobs:
platform_matrix:
Expand All @@ -47,6 +58,7 @@ jobs:
matrix:
include: ${{ fromJSON(needs.platform_matrix.outputs.dev_matrix) }}
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.os == 'macos-14' && inputs.allow_macos_failure == 'true' }}
steps:
- name: Checkout Source
uses: actions/checkout@v4
Expand Down
Loading