Fail fast with a clear message when gau2grid's Python lacks numpy - #77
Merged
Conversation
gau2grid's own CMakeLists only requires COMPONENTS Interpreter and never checks numpy is importable before wiring its codegen up as a build-time custom command, so a plain find_package(Python) that lands on a numpy-less interpreter fails late with a cryptic traceback instead of a clear configure-time error. Resolve and validate the interpreter here, mirroring skbuild_python.cmake's FATAL_ERROR pattern, and pin gau2grid to the exact interpreter validated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Both unconditionally add -Wall -Wextra -Wpedantic -Wnon-virtual-dtor -Wshadow as PRIVATE compile options to their own sources, with no option() to opt out, flooding the build log with warnings from code we don't maintain. Append -w after their own flags on the gauxc/exchcxx targets once fetched; since it's added later it wins over their earlier -W* flags for GCC/Clang/AppleClang, and being PRIVATE it has no effect on SCF's own compilation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gau2grid's own CMakeLists only requires COMPONENTS Interpreter and never checks numpy is importable before wiring its codegen up as a build-time custom command, so a plain find_package(Python) that lands on a numpy-less interpreter fails late with a cryptic traceback instead of a clear configure-time error. Resolve and validate the interpreter here, mirroring skbuild_python.cmake's FATAL_ERROR pattern, and pin gau2grid to the exact interpreter validated.