Disable ccache for libxc's targets - #80
Merged
Merged
Conversation
A ccache entry for one of libxc's object files was found corrupted/ truncated (most likely from a prior cancelled or OOM-killed CI run) and served as a false hit: it built and linked cleanly but crashed with SIGILL at runtime deep inside a libxc functional evaluation. Reproduced and confirmed fixed by manually clearing the ccache-Linux-gcc-14-* cache entry on NWChemEx/SCF#70. Clear C_COMPILER_LAUNCHER/CXX_COMPILER_LAUNCHER on libxc's targets right after FetchContent_MakeAvailable so this specific dependency never goes through ccache. Its own build is a few seconds, and FetchContent already caches the source checkout separately, so the object-level reuse ccache would provide here is cheap to give up in exchange for not silently resurrecting this bug from a future corrupted cache entry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGILLat runtime deep inside a libxc functional evaluation (test_unit_scf/test_integration_scf's libxc SVWN3 tests, seen intermittently on NWChemEx/SCF#70'stest_cmake_build (ubuntu-latest, gcc-14)leg).ccache-Linux-gcc-14-*GitHub Actions cache and re-running fixed the real PR job. Root cause is a bad cache entry, not libxc's source, GCC, or CPU/ISA.C_COMPILER_LAUNCHER/CXX_COMPILER_LAUNCHERon libxc's targets (xc, andxcf03if Fortran bindings are enabled) right afterFetchContent_MakeAvailable(libxc), so this one dependency is never routed through ccache. Its own build is a few seconds, and FetchContent already caches the source checkout separately, so the object-level reuse given up here is cheap insurance.Test plan
set_target_properties(<tgt> PROPERTIES C_COMPILER_LAUNCHER "")afteradd_librarycorrectly drops theLAUNCHERfrom that target's Ninja compile rule while a sibling target keeps the global launcher.🤖 Generated with Claude Code