Migrate CI and dependencies from ryanmrichard to NWChemEx - #163
Merged
Conversation
…cmake_build Fork-test-only commit: points merge.yaml/pull_request.yaml at the ryanmrichard/.github fork's reusable workflows instead of the real NWChemEx/.github, triggers off build_overhaul (this fork's working branch), and swaps the older test_nwx_library job for test_nwx_cmake_build (run_python_tests disabled; no Python bindings on this branch yet).
…ting The nwx_set_version refactor this branch depends on only exists on ryanmrichard/NWXCMake's master (fork-tested); NWChemEx/NWXCMake's master doesn't have it yet, so the git-fallback FetchContent needs to point at the fork too, same as the CI workflow retargeting.
…o fork Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… publishing) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Repoints this repo's workflows at NWChemEx/.github (landed in NWChemEx/.github#187) instead of the ryanmrichard fork they were developed against, and switches merge.yaml's and pull_request.yaml's branch triggers from build_overhaul to master now that master is the ecosystem's working branch. Drops the test.pypi.org repository-url override on the merge workflow's publish step, so a merge to master publishes to real PyPI -- nwchemex-utilities is free there and a trusted publisher has been registered for it. get_nwx_cmake.cmake's FetchContent fallback and pyproject.toml's runtime dependency both repoint at NWChemEx/NWXCMake; the latter also switches from a git+ dependency to a published floor (nwchemex-nwxcmake>=0.1.0), now that NWXCMake has an actual PyPI release to pin against.
test_pip_build was failing with "pytest: command not found" -- this repo has no tests/ directory and its dev extra doesn't even include pytest, but test_nwx_pip_build.yaml runs pytest by default. Set run_python_tests: "false" here too, matching the override test_cmake_build already had. Same fix in nightly.yaml, which mirrors pull_request.yaml's job list but has never actually run (GitHub only fires schedule triggers from the default branch, which this repo is only just becoming).
…_SETUP) Setting run_python_tests: "false" switches pip_build's install to the non-editable "pip install ." path. This repo's pyproject.toml only sets -DDEVELOPER_SETUP=ON for an *editable* install (the [[tool.scikit-build.overrides]] with if.state = "editable"), and DEVELOPER_SETUP is what actually wires up the CMake test targets -- BUILD_TESTING alone isn't enough. So the non-editable install builds with zero CTest tests registered, and run_cmake_tests (still defaulting to "true") then fails with "zero CTest tests were found". test_cmake_build already exercises the real CTest suite directly (DEVELOPER_SETUP=ON unconditionally there), so test_pip_build doesn't need to duplicate it -- set run_cmake_tests: "false" too, so this job only verifies that a plain `pip install .` succeeds.
Contributor
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/{merge,pull_request,nightly}.yamlfromryanmrichard/.githubtoNWChemEx/.github(landed in Land the build/CI overhaul's shared workflows and actions .github#187).merge.yaml's andpull_request.yaml's branch triggers frombuild_overhaultomaster--masteris now the ecosystem's working branch.test.pypi.orgrepository-urloverride from the merge workflow's publish step, so merging tomasterpublishesnwchemex-utilitiesto real PyPI (trusted publisher registered).cmake/get_nwx_cmake.cmake's FetchContent fallback andpyproject.toml's runtime dependency atNWChemEx/NWXCMake, switching the latter from agit+dependency to a published floor (nwchemex-nwxcmake>=0.1.0) now that NWXCMake has a PyPI release.This is part of the ecosystem-wide migration off the
ryanmrichardpersonal fork/account;build_overhaulhere already matches the org'sbuild_overhaulbranch, so this PR is purely the CI/dependency repoint.Test plan
NWChemEx/.githubreusable workflows)nwchemex-utilitiespublishes to PyPI on merge, floored correctly againstnwchemex-nwxcmake>=0.1.0