Skip to content

Add COLP usetypes mapping as dbt seed#2280

Open
alexrichey wants to merge 1 commit intomainfrom
ar-colp-usetypes
Open

Add COLP usetypes mapping as dbt seed#2280
alexrichey wants to merge 1 commit intomainfrom
ar-colp-usetypes

Conversation

@alexrichey
Copy link
Copy Markdown
Contributor

@alexrichey alexrichey commented Mar 19, 2026

USE TYPES

Unfortunately (see here) DCAS IPIS usetypes changed from full to truncated versions. We should ask them about this, but in the meantime it was easy enough to just make a translations table from the newer truncated types (e.g. "POLLUTION CONTRL FAC") to the older versions ("POLLUTION CONTROL FACILITY") to maintain stability.

There are only two newer truncated types that we're seeing now, but haven't seen before:
"EMERGENCY MEDICL STN"
"COURT (SPORTS)"
I'm going to leave these be. All other types are accounted for.

OTHER REFACTORS

I don't have geosupport locally, so I broke the scripts apart to enable running just the sql part of things.

Copy link
Copy Markdown
Member

@damonmcc damonmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth squashing the commits

@alexrichey
Copy link
Copy Markdown
Contributor Author

@damonmcc FYI, going to wait to hear back from DCAS about data issues before merging this. We might just be able to discard the seed

trim the uses

remove carriage-returns in usetype_mappings.csv

dbt'ify COLP seeds

Add all the build-engine vars

Integrate usetype_mappings into COLP build

- Update categorized CTE to use usetype_mapped instead of normed_name_merge
- This ensures cleaned usetype values from usetype_mappings seed are used
- All 75 mapped values now display cleaned versions in final COLP output
- Closes de-3oz.3

add a few more mappings

split the scripts (for local running)

chmod!

kill my old usetype_mappings (non seed) csv
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.03%. Comparing base (1082480) to head (846eb70).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants