refactor: improve testability and prevent film repetition on reroll - #66
Merged
Conversation
Add utility function to get a random element from a set while excluding a specific element using a key selector for comparison. Includes comprehensive unit tests.
…petition Replace hardcoded Dispatchers.IO with injected DispatcherProvider for better testability. Use randomExcluding to avoid showing the same film on reroll. Wrap repository calls in withContext(dispatchers.io). Conditionally show reroll button only when numberOfResults > 1.
Fix reroll button test by passing numberOfResults parameter. Add test to verify loading animation completes full cycle for better code coverage.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the RandomFilm feature's testability by using injected dispatchers instead of hardcoded Dispatchers.IO, and prevents the same film from being shown consecutively when using the reroll feature.
RandomFilm Feature
Tests