Skip to content

[WIP] AsyncImageView: allow manually displaying placeholder #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NachoSoto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] AsyncImageView: allow manually displaying placeholder #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 43 additions & 6 deletions AsyncImageView/AsyncImageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,45 @@ open class AsyncImageView<
PlaceholderRenderer.Error == NoError,
Renderer.RenderResult == PlaceholderRenderer.RenderResult
{
private let requestsSignal: Signal<Data?, NoError>
private let requestsObserver: Signal<Data?, NoError>.Observer
public enum Display {
case empty
case placeholder
case data(ImageViewData)

fileprivate func renderDataWithSize(_ size: CGSize) -> DataDisplay {
switch self {
case .empty:
return .empty
case .placeholder:
return .placeholder
case let .data(data):
return .data(data.renderDataWithSize(size))
}
}
}

fileprivate enum DataDisplay: Equatable {
case empty
case placeholder
case data(Data)

static func == (lhs: DataDisplay, rhs: DataDisplay) -> Bool {
switch (lhs, rhs) {
case (.empty, .empty):
return true
case (.placeholder, .placeholder):
return true
case let (.data(lhs), .data(rhs)):
return lhs == rhs

default:
return false
}
}
}

private let requestsSignal: Signal<DataDisplay, NoError>
private let requestsObserver: Signal<DataDisplay, NoError>.Observer

private let imageCreationScheduler: Scheduler

Expand All @@ -56,7 +93,7 @@ open class AsyncImageView<
.on(value: { [weak self] in
if
let strongSelf = self,
placeholderRenderer == nil || $0 == nil {
placeholderRenderer == nil || $0 == .empty {
strongSelf.resetImage()
}
})
Expand Down Expand Up @@ -98,7 +135,7 @@ open class AsyncImageView<
}
}

public final var data: ImageViewData? {
public final var data: Display {
didSet {
self.requestNewImageIfReady()
}
Expand All @@ -117,10 +154,10 @@ open class AsyncImageView<
}
}

private func requestNewImage(_ size: CGSize, data: ImageViewData?) {
private func requestNewImage(_ size: CGSize, data: Display) {
self.imageCreationScheduler.schedule { [weak instance = self, observer = self.requestsObserver] in
if instance != nil {
observer.send(value: data?.renderDataWithSize(size))
observer.send(value: data.renderDataWithSize(size))
}
}
}
Expand Down