Skip to content

Fix test warnings #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NachoSoto merged 15 commits into from
Nov 30, 2025
Merged

Fix test warnings #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
78198c8
Add macOS CI workflow
NachoSoto Nov 30, 2025
37b59d1
Merge branch 'master' into codex/add-github-workflow-for-build-and-test
NachoSoto Nov 30, 2025
018deb4
Update .github/workflows/build-and-test.yml
NachoSoto Nov 30, 2025
de90238
Update .github/workflows/build-and-test.yml
NachoSoto Nov 30, 2025
b69be94
Update build-and-test.yml
NachoSoto Nov 30, 2025
0e75c91
Update build-and-test.yml
NachoSoto Nov 30, 2025
826d93a
Update build-and-test.yml
NachoSoto Nov 30, 2025
cc70c65
Fix QuickSpec overrides and imports (#62)
NachoSoto Nov 30, 2025
4220b8e
Fix cache specs to compile with Quick (#63)
NachoSoto Nov 30, 2025
74e1335
Fix test warnings
NachoSoto Nov 30, 2025
ad370b6
Update CachingSpec.swift
NachoSoto Nov 30, 2025
8ff5e52
Update CachingSpec.swift
NachoSoto Nov 30, 2025
d4f713e
Merge branch 'master' into codex/fix-build-warnings-in-tests
NachoSoto Nov 30, 2025
321641e
Add warnings-as-errors flag to CI build (#65)
NachoSoto Nov 30, 2025
9c4b532
Update build-and-test.yml
NachoSoto Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,5 @@ jobs:
scheme: AsyncImageView
platform: iOS
action: test
warnings-as-errors: false
verbosity: xcbeautify
4 changes: 2 additions & 2 deletions AsyncImageViewTests/CachingSpec.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class RenderDataTypeCacheSubdirectorySpec: QuickSpec {
}
}

extension String: DataFileType {
extension String: @retroactive DataFileType {
public var subdirectory: String? {
return "\(self.count)"
}
Expand All @@ -152,7 +152,7 @@ extension String: DataFileType {
}
}

extension String: NSDataConvertible {
extension String: @retroactive NSDataConvertible {
public init?(data: Data) {
self.init(data: data, encoding: String.encoding)
}
Expand Down
8 changes: 4 additions & 4 deletions AsyncImageViewTests/MulticastedRendererSpec.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class MulticastedRendererSpec: QuickSpec {
}

func getImageForData(_ data: TestData, _ size: CGSize) -> ImageResult? {
return try? getProducerForData(data, size)
return getProducerForData(data, size)
.single()?
.get()
}
Expand All @@ -56,8 +56,8 @@ class MulticastedRendererSpec: QuickSpec {
let result2 = getProducerForData(data, size)

// Starting the producers should yield the same image.
guard let image1 = try? result1.single()?.get().image else { XCTFail("Failed to produce image"); return }
guard let image2 = try? result2.single()?.get().image else { XCTFail("Failed to produce image"); return }
guard let image1 = result1.single()?.get().image else { XCTFail("Failed to produce image"); return }
guard let image2 = result2.single()?.get().image else { XCTFail("Failed to produce image"); return }

expect(image1) === image2
}
Expand All @@ -82,7 +82,7 @@ class MulticastedRendererSpec: QuickSpec {
}

func getImageForData(_ data: TestData, _ size: CGSize) -> ImageResult? {
return try? getProducerForData(data, size)
return getProducerForData(data, size)
.single()?
.get()
}
Expand Down