Fix incorrect certificate expiry calculation in local-certs check #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local-certs check type was incorrectly calculating the number of days until certificate expiration. The bug was in the warning threshold comparison where it calculated the difference between the warning threshold date and the expiry date, instead of calculating the actual remaining days from now until expiration. Before this fix: - diff = (warning - expiry) / 86400 where warning = now + expiry_warn_days - This resulted in reporting (expiry_warn_days - actual_remaining_days) instead of the actual remaining days Example of incorrect behavior: - Current date: December 1, 2025 - Certificate expires: December 29, 2025 - Warning threshold: 30 days - Reported: "will expire in 2 days" (incorrect) - Should report: "will expire in 28 days" (correct) After this fix: - diff = (expiry - rightnow) / 86400 - This correctly reports the actual number of days remaining until expiration The fix aligns the warning calculation logic with the expired certificate calculation logic, which was already using (rightnow - expiry) correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local-certs check type was incorrectly calculating the number of days until certificate expiration. The bug was in the warning threshold comparison where it calculated the difference between the warning threshold date and the expiry date, instead of calculating the actual remaining days from now until expiration.
Before this fix:
Example of incorrect behavior:
After this fix:
The fix aligns the warning calculation logic with the expired certificate calculation logic, which was already using (rightnow - expiry) correctly.