fix(ci): SHA-pin actions/checkout + actions/setup-python (closes #19)#20
Open
fix(ci): SHA-pin actions/checkout + actions/setup-python (closes #19)#20
Conversation
Pin `actions/checkout@v4` and `actions/setup-python@v5` to commit SHAs across 8 references in ci.yml. Zero behavioural change — same commits the floating tags currently resolve to. Surfaced by the cross-org SHA-pin audit (Gridltd-DevOps/.github#193). The enterprise SHA Pin Enforce ruleset would otherwise block any future PR touching this file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@MastLuo please review the SHA-pin fix when convenient. |
There was a problem hiding this comment.
Pull request overview
Pins GitHub Actions used in the CI workflow to immutable commit SHAs to comply with SHA-pin enforcement rules (closes #19), while preserving the same action revisions currently referenced by the floating tags.
Changes:
- Replace
actions/checkout@v4withactions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5in all jobs. - Replace
actions/setup-python@v5withactions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065in all jobs. - Add inline comments indicating the pinned major versions (
# v4,# v5).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
actions/checkout@v4(4×) andactions/setup-python@v5(4×) to commit SHAs across.github/workflows/ci.yml. Zero behavioural change — same commits the floating tags currently point to.Why
Tags are mutable. Pinning to SHA is the enterprise standard per Gridltd-DevOps/.github#193. The SHA Pin Enforce ruleset will block any future PR touching this file otherwise.
Test Plan
Related Issue
Closes #19. Parent: Gridltd-DevOps/.github#193 (cross-org SHA-pin audit).
🤖 Generated with Claude Code