fix: use git-only metadata for updater --gui channel picker#159
Conversation
Skip GitHub REST API for branch and commit lists when --gui is set so unauthenticated clients avoid rate limits; keep API-first path elsewhere.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nat3z
left a comment
There was a problem hiding this comment.
@nat-openclaw please fix all of these.
| } | ||
|
|
||
| ipcMain.handle('get-branches', async () => { | ||
| if (hasArg('--gui')) { |
There was a problem hiding this comment.
@nat-openclaw get rid of the original github api implementation and simplify it to just the git version.
| ipcMain.handle('get-recent-commits', async (_event, branch) => { | ||
| const targetBranch = | ||
| typeof branch === 'string' && branch ? branch : DEFAULT_BLEEDING_EDGE_BRANCH; | ||
| if (hasArg('--gui')) { |
|
|
|
|
Fixed both review points in Built it with |
|
Yep — I stripped out the original GitHub API path for branch/commit metadata, so both I also ran |
|
I re-ran Ready for another look when you are. |
Summary
--gui, branch list and recent commit metadata load via git only (getBranchesViaGit/getRecentCommitsViaGit), avoiding unauthenticated GitHub REST API calls that hit rate limits.--guipaths keep the existing GitHub API-first flow with git fallback on rate-limit errors./releases) after channel selection are unchanged.Closes #158
Test plan
bun run buildinupdater/(TypeScript compile)--gui, open bleeding-edge picker; confirm branches/commits load withoutapi.github.comcalls for branches/commitsMade with Cursor