Skip to content

fix: replace IPC timeout fallback with renderer handshake#166

Open
nat-openclaw wants to merge 1 commit into
mainfrom
nat-openclaw/issue-165-issue-165-1780876126062-dzjw2m
Open

fix: replace IPC timeout fallback with renderer handshake#166
nat-openclaw wants to merge 1 commit into
mainfrom
nat-openclaw/issue-165-issue-165-1780876126062-dzjw2m

Conversation

@nat-openclaw

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the 15s IPC_READY_TIMEOUT_MS fallback in sendIPCMessage that could dispatch main→renderer IPC before the client was listening
  • Gate IPC on a proper handshake: did-finish-load for the main app page plus the existing client-ready-for-events signal from the renderer
  • Run onMainAppReady after the renderer handshake completes (normal startup, game launch, and hook-only launch paths)

Closes #165

Test plan

  • bun run typecheck in application/
  • Manual startup: verify all-addons-started, addon-connected, and addon-runtime-ready reach the frontend reliably
  • Manual --game-id and hook-only launch paths still show the main UI and receive startup IPC

Made with Cursor

@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
open-game-installer-web Ready Ready Preview, Comment Jun 7, 2026 11:51pm

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41d6359b-b4a3-40c4-ad4c-ea0214de29db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nat-openclaw/issue-165-issue-165-1780876126062-dzjw2m

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix IPC race conditions in main.ts - replace manual timeouts with proper handshake mechanism

1 participant