refactor: replace Express instance bridge with Electron single-instance lock#167
refactor: replace Express instance bridge with Electron single-instance lock#167nat-openclaw wants to merge 1 commit into
Conversation
…ce lock Use app.requestSingleInstanceLock and the second-instance event for focus and launch handoff instead of HTTP /internal routes on port 7654. Simplify addon-server to run AddonServer directly without Express.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nat3z
left a comment
There was a problem hiding this comment.
really clean, but will this allow for, if an instance is open already and steam requests launch, have it still launch the game via the existing instance @nat-openclaw /ask
|
I hit an infra error before I could finish: React to this comment with 🚀 to retry. |
|
@nat-openclaw try again /ask |
|
Asked and answered — no code changes were made for |
|
Yep — Steam launching a second process should still work. With this refactor, the second launch is handled by Electron’s So: no duplicate app, still launches the game. Tiny bit less HTTP, same “do the right thing” energy. |
Summary
/internal/*instance bridge on port 7654 with Electron'srequestSingleInstanceLock()andsecond-instanceeventaddon-server.tsto runAddonServerdirectly without Expressexpressand@types/expressdependencies from the application packageCloses #163
Test plan
bun run typecheckinapplication/--game-id=on second launch forwards game launch to running instance--pre/--post/--no-launchhook launches work on second instance--still works on second instanceMade with Cursor