Skip to content

fix: Windows UAC elevation for game launches#169

Closed
nat-openclaw wants to merge 1 commit into
mainfrom
nat-openclaw/issue-168-issue-168-1781200933817-9nux56
Closed

fix: Windows UAC elevation for game launches#169
nat-openclaw wants to merge 1 commit into
mainfrom
nat-openclaw/issue-168-issue-168-1781200933817-9nux56

Conversation

@nat-openclaw

@nat-openclaw nat-openclaw commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes Windows legacy game launches failing silently when an executable requires administrator privileges
  • Routes Windows launches through PowerShell Start-Process (ShellExecute) instead of child_process.spawn (CreateProcess), so Windows can show the UAC elevation prompt for requireAdministrator manifests
  • Preserves cwd, launch arguments, and launch environment variables; exit handling remains wired through the PowerShell wrapper process

Test plan

  • bun run build:all && bun run typecheck in application/
  • On Windows, launch a game whose executable requires admin rights and confirm the UAC prompt appears
  • On Windows, launch a normal non-elevated game and confirm it still starts correctly
  • On Linux, confirm legacy/UMU launches are unchanged

Closes #168

Made with Cursor

@nat-openclaw @cursoragent
fix: use ShellExecute for Windows game launches to allow UAC elevation
f544616 
child_process.spawn uses CreateProcess and cannot show the UAC prompt for
executables that require administrator privileges. Route Windows legacy
launches through PowerShell Start-Process so ShellExecute handles manifest
elevation requests.

Closes #168

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
open-game-installer-web Ready Ready Preview, Comment Jun 11, 2026 6:06pm

@nat-openclaw nat-openclaw mentioned this pull request Jun 11, 2026
Open
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 235c9d18-163b-4c0d-ad41-f24c05c2f878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nat-openclaw/issue-168-issue-168-1781200933817-9nux56

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nat3z

Nat3z commented Jun 11, 2026

Copy link
Copy Markdown
Owner

closing this pr. i don't like this solution. this is why we don't vibe-code lol

@Nat3z Nat3z closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

windows user admin escalation issue with launching

2 participants

@nat-openclaw @Nat3z