Open
Conversation
…ackup capacity. Still debugging using control signals correctly.
…t why initialization is affected and the backup element isn't being controlled right
Merge in the latest changes to dev to the external-hvac control branch. This is just getting external-hvac up to date to make merging easier later.
Apply ruff format to fix comment spacing, quote style, trailing whitespace, and line length violations that caused CI lint failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #213. OCHRE is supposed to be able to handle a capacity (calculated from an external HVAC module for example) being passed in as a control signal, but for an ASHP in heating mode the backup capacity control signal appears to be ignored and the controls are affecting warmup.