Skip to content

Adds more documentation around start()/stop() Tracker methods - #24

Merged
weslleyspereira merged 3 commits into
mainfrom
12-trackerstart-trackerstop-never-writes-an-output-file
Sep 8, 2026
Merged

Adds more documentation around start()/stop() Tracker methods#24
weslleyspereira merged 3 commits into
mainfrom
12-trackerstart-trackerstop-never-writes-an-output-file

Conversation

@weslleyspereira

Copy link
Copy Markdown
Collaborator

Closes #12.

@weslleyspereira weslleyspereira linked an issue Aug 20, 2026 that may be closed by this pull request
@weslleyspereira
weslleyspereira force-pushed the 12-trackerstart-trackerstop-never-writes-an-output-file branch from c9a5466 to baeb736 Compare August 21, 2026 14:19
@Deln0r

Deln0r commented Aug 28, 2026

Copy link
Copy Markdown

Verified at 485d1d2 by running it rather than reading the diff.

The reproducer from #12 now writes: start() then stop() with no arguments gives the same 532-byte file as the context manager. On 3d6aa73 it gives nothing. Suite is 186 passed, 5 skipped.

On the new sentence about starting and stopping one tracker several times: with output= set, every start() appends another # timestamp header, and file_to_df then stops there with ValueError: time data '#' does not match format.

That is not new here, write_header has always appended, but the sentence sends users into it. Either drop the sentence, or let file_to_df skip comment lines.

@weslleyspereira

Copy link
Copy Markdown
Collaborator Author

Thanks for the find! It should be fixed now

@weslleyspereira
weslleyspereira merged commit a923c83 into main Sep 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tracker.start() / tracker.stop() never writes an output file

3 participants