fix: MQTT v2 callback API and disconnect leak (#15, #16) - #32
Open
xtruan wants to merge 4 commits into
Open
Conversation
…bRockies#16) Issue NatLabRockies#15: mqtt_publisher used the deprecated paho-mqtt v1 callback API while pyproject requires paho-mqtt>=2.0.0, producing a DeprecationWarning and future breakage. - Construct mqtt.Client with callback_api_version=VERSION2 - Update _on_connect/_on_disconnect/_on_publish to the v2 signatures, handling ReasonCode objects (is_failure/value) Issue NatLabRockies#16: the MQTT publisher's network-loop thread was never stopped and no DISCONNECT was sent on teardown (resource leak). - Add Tracker.disconnect_mqtt() (idempotent) and a stop() override that disconnects in a finally block - Route Tracker.__exit__ and track_until_forced_exit through the cleanup - Add matching cleanup to TrackerArray for all child trackers Update the test FakeMQTTModule to the v2 API and add regression tests covering both issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #15: mqtt_publisher used the deprecated paho-mqtt v1 callback API while pyproject requires paho-mqtt>=2.0.0, producing a DeprecationWarning and future breakage.
Issue #16: the MQTT publisher's network-loop thread was never stopped and no DISCONNECT was sent on teardown (resource leak).
Update the test FakeMQTTModule to the v2 API and add regression tests covering both issues.