Reduce duplicate code into hidden _auxiliary module#30
Merged
Conversation
…e user-facing later, depending on usefulness
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 60.16% 60.26% +0.10%
==========================================
Files 42 43 +1
Lines 1998 2001 +3
==========================================
+ Hits 1202 1206 +4
+ Misses 796 795 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c-randall
marked this pull request as ready for review
May 14, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some functions had repeated logic across modules (e.g., inferring states, computing SOC, detecting pulses, etc.). A new
auxiliarymodule was added for developers to put these helper functions into one place instead of scattering and repeating them all over. Depending on how useful some of these functions are, they may also be considered to be user-facing at a later point.This is a smaller PR to initialize this new module. An additional PR will include functions to infer steps, cycles, add a cumulative steps column, and to detect pulses (mentioned above, but not included here).
Type of change
Key checklist:
$ nox -s linter [-- format]$ nox -s codespell [-- write]$ nox -s testsFurther checks:
$ nox -s docs.