Feature/split out resources#246
Merged
genevievestarke merged 6 commits intoNatLabRockies:developfrom Apr 9, 2026
Merged
Conversation
4 tasks
Collaborator
|
Hi @paulf81, this looks great! Would you be able to adjust one of the resource examples to show how the sub package is loaded/works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #221 implemented a refactor of the resources module, but because included both file changes, and movement from a monolith file into seperate files, was hard to review because the specific changes were hard to observe.
This PR starts a more incremental approach by for now only splitting out the contents of
hercules/resource/wind_solar_resource_downloader.pyinto seperate module files, without any additional changes except for correcting the imports. Specifically starting from:Move to:
And then only make changes where these are imported in examples and discussed in docs. This way future modularization changes, as in #221 can be implemented without also including movement of code between files. (Specifically #221 moves repeated code blocks within the download scripts into new shared functions and that is not done here. The individual functions are moved as is)