Improve terminal printout#251
Open
misi9170 wants to merge 4 commits intoNatLabRockies:developfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Hercules’ terminal/log output by cleaning up the end-of-run timing summary, making it more readable and removing the “x real time” line that was previously printed as a tuple.
Changes:
- Replace tuple-based logging of “Total simulated time” with a single formatted string.
- Format wall time with units and fixed precision, and remove the “Rate of simulation … x real time” log line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@genevievestarke @paulf81 tagging you in case you have any other suggestions for cleaning up the screen printout while I'm at it (and perhaps weigh in on the |
Collaborator
|
I changed it so that it only prints out if verbose = True. I also got rid of an old AMR wind file I found floating around in the examples. This seemed like a good PR to put that in, too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR fixes some bad formatting in the printout provided by Hercules. It also removes the line stating the speed-up of Hercules relative to real time, as this probably isn't super relevant for most users and can be easily calculated from what is still printed to screen. However, this second change can be easily reverted if we still want the speed up information.
Example printout prior to the change:
After the change:
I'm not totally sure what the
read in verbose flag = Falseis meant to be used for, so perhaps that could also be addressed in this PR?