[integrations] Telegram capture#43
[integrations] Telegram capture#43alanshurafa wants to merge 2 commits intoNateBJones-Projects:mainfrom
Conversation
|
Saw your Discord post — impressive work across all of these. I'm going to personally review each one. Not today, but they're on my list. |
justfinethanku
left a comment
There was a problem hiding this comment.
Review of PR #43: [integrations] Telegram capture
What's Good
This is a high-quality contribution that shows clear attention to the contribution standards:
- Excellent documentation - The README is thorough, well-structured, and follows all required sections (Prerequisites, Credential Tracker, Steps, Expected Outcome, Troubleshooting)
- Production-tested - The author is running this in production with 75,000+ thoughts, which is strong validation
- Complete metadata.json - All required fields are present and properly formatted
- Security-conscious - Uses environment variables correctly, no hardcoded credentials
- Safe SQL - No DROP, TRUNCATE, or other dangerous operations
- Correct folder structure - Lives in
integrations/telegram-capture/as expected - Proper PR title format - Follows
[category] descriptionconvention - Mobile-first value prop - Fills a real gap (mobile capture with voice-to-text support)
- Clear cost section - Helpful transparency about OpenRouter API costs
Issues Found
Critical (must fix before merge):
-
MCP server pattern violation - The Edge Function code is correct and follows the remote MCP pattern, but the README needs to explicitly state that this does NOT require modifying
claude_desktop_config.jsonor running a local MCP server. Per CONTRIBUTING.md line 194: "Extensions and integrations must use remote MCP via Supabase Edge Functions. Noclaude_desktop_config.json, no local Node.js stdio servers."Fix: Add a note in the Prerequisites or early in Step 3 clarifying: "This integration uses Supabase Edge Functions (remote execution) and does not require any MCP server configuration or modifications to Claude Desktop settings."
-
Missing confirmation of automated review - The PR checklist references automated review checks, but
gh pr checksshows no checks have run. This suggests the automated review workflow (.github/workflows/ob1-review.yml) hasn't executed yet.Fix: Ensure the automated review workflow runs and passes before merge.
Nice-to-haves (suggestions, not blockers):
-
Credential tracker - The credential tracker is excellent, but could benefit from one additional field:
Webhook confirmation URL: https://api.telegram.org/bot______/getWebhookInfoThis would help users verify setup later.
-
Cross-reference - Consider adding a "Related integrations" section linking to
../slack-capture/since the README already mentions it in the intro. -
Troubleshooting expansion - The voice messages section is good but could add: "To enable transcription in Telegram: Settings → Chat Settings → Voice-to-Text"
Review Checklist
✅ Folder structure correct (integrations/telegram-capture/)
✅ Required files present (README.md + metadata.json)
✅ metadata.json has all required fields and valid values
✅ No credentials, API keys, or secrets in code
✅ SQL safety (no dangerous operations)
✅ README completeness (all sections present)
✅ PR title format correct
✅ No binary blobs over 1MB
Verdict: Minor fixes needed
This is a solid contribution that will be ready to merge once:
- The MCP pattern is clarified in the README (add one note stating this doesn't require local MCP server setup)
- The automated review checks pass
The author clearly understands the project standards and has built something valuable. The fixes are documentation clarifications, not code changes.
Great work, @alanshurafa! Looking forward to merging this once the minor items are addressed.
Send thoughts from Telegram, auto-embedded and classified into Open Brain. Runs as a remote Supabase Edge Function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ec3ee9e to
88e80bc
Compare
Replace 5-type (observation, task, idea, reference, person_note) with the canonical 8-type system used across Open Brain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Why Telegram?
Telegram fills the mobile capture gap. Slack is great at a desk, but Telegram is lighter on phones, works offline (messages queue), and has built-in voice-to-text — ideal for capturing thoughts on the go.
What's Included
integrations/telegram-capture/metadata.json— OB1-format metadataintegrations/telegram-capture/README.md— Full walkthrough with 5 numbered steps:Production Tested
This integration is running in production on my personal Open Brain instance (ExoCortex) with ~75,000 thoughts. The production version has additional features (duplicate detection, sensitivity classification, structured capture formats, event logging) that can be upstreamed in future PRs if there's interest.
Test plan
integrations/telegram-capture/[category] descriptionformat🤖 Generated with Claude Code