[DO NOT MERGE - TEST ONLY] test(sio2man): 2023 pre-rewrite sio2man swap - KrahJohlito confirmation build (#340) - #357
Draft
NathanNeurotic wants to merge 2 commits into
Draft
Conversation
…tion) The HUD 'PAD miss:' line has had no writers since the PR #328 revert -- it always rendered miss:0 regardless of hardware behavior. Count ready- state polls that produce no fresh sample so testers can see whether the priority-ceiling sio2man actually drives the miss rate to zero. No behavior change: diagnostics only, repeat handling untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…Y, DO NOT MERGE (#340) Confirmation experiment requested by KrahJohlito: embed the threaded prio-24 sio2man extracted verbatim from uOPL's pinned 2023-09-09 CI container (import fingerprint thbase+thevent, no thsemap) in place of the SDK's current threadless freesio2.irx, everything else stock plus the Debug-HUD miss counters. If the D-pad drop/queue issue disappears on this build, the ps2sdk threadless sio2man rewrite (PR ps2homebrew#709) is confirmed as the trigger on real hardware. Expected side effects: MMCE and MX4SIO menu features may break (they require the modern sio2man API) -- USB-boot test rig only. See modules/sio2man-2023/PROVENANCE-TEST.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST BUILD C of 3 — DIAGNOSTIC ONLY, never mergeable. This is the confirmation experiment KrahJohlito asked for: "Best way to test... load sio2man from that build instead of latest... confirm older module works around the issue first."
What it is
Stock RiptOPL master + exactly two changes:
ghcr.io/ps2dev/ps2dev@sha256:362bcd26…, image created 2023-09-09). Import fingerprint verified:thbase+thevent(dedicated prio-24 worker thread + event flags), nothsemap— the threaded design. sha256 inmodules/sio2man-2023/PROVENANCE-TEST.md.No repeat-engine changes, no ceiling patch. Pure module A/B against the same console.
Expected breakage — do NOT report as bugs
What the result means
PAD miss:~0miss:0Any of the three outcomes is decisive data. One session of navigation with Debug Colors ON answers it.
🤖 Generated with Claude Code