Skip to content

[commithelper-go] add better error handling for protect option#65

Merged
djk01281 merged 2 commits intoNaverPayDev:mainfrom
djk01281:feature/protect-pattern-error-handling
Feb 19, 2026
Merged

[commithelper-go] add better error handling for protect option#65
djk01281 merged 2 commits intoNaverPayDev:mainfrom
djk01281:feature/protect-pattern-error-handling

Conversation

@djk01281
Copy link
Contributor

Related Issue

Describe your changes

  • Return error for invalid protect patterns (e.g. unclosed [) instead of silently ignoring them
  • Improve tests with t.Run subtests and add invalid pattern error test case
  • Document nested branch matching behavior in README

Request

@djk01281 djk01281 self-assigned this Feb 19, 2026
@djk01281 djk01281 requested a review from a team as a code owner February 19, 2026 11:12
@djk01281 djk01281 changed the title Feature/protect pattern error handling [commithelper-go] add better error handling for protect option Feb 19, 2026
@djk01281 djk01281 force-pushed the feature/protect-pattern-error-handling branch from 2996ca2 to 975829d Compare February 19, 2026 11:19
Copy link
Collaborator

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djk01281 djk01281 force-pushed the feature/protect-pattern-error-handling branch from 975829d to 5e93334 Compare February 19, 2026 11:20
@djk01281 djk01281 merged commit 9486ce9 into NaverPayDev:main Feb 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments