Skip to content

[eslint-plugin] peer-deps-in-dev-deps#102

Merged
yongholeeme merged 6 commits intomainfrom
feature/97_peerDepsInDevDeps
Mar 31, 2025
Merged

[eslint-plugin] peer-deps-in-dev-deps#102
yongholeeme merged 6 commits intomainfrom
feature/97_peerDepsInDevDeps

Conversation

@yongholeeme
Copy link
Contributor

@yongholeeme yongholeeme commented Mar 13, 2025

Related Issue

#97

Describe your changes

improve report location in peer-deps-in-dev-deps

  • asis: report all
  • tobe: report devDeps, and if not present, peerDeps
asis tobe tobe
asis tobe-devDeps tobe-peerDeps

@yongholeeme yongholeeme self-assigned this Mar 13, 2025
@yongholeeme yongholeeme force-pushed the feature/97_peerDepsInDevDeps branch from d1cc0c3 to 15b9ed0 Compare March 13, 2025 04:44
@npayfebot
Copy link
Contributor

npayfebot commented Mar 13, 2025

✅ Changeset detected

Latest commit: ed4e86a

@naverpay/eslint-plugin, @naverpay/prettier-config, @naverpay/stylelint-config packages have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

powered by: naverpay changeset detect-add actions

@yongholeeme yongholeeme changed the base branch from main to feature/83_json March 13, 2025 04:44
Base automatically changed from feature/83_json to main March 13, 2025 04:46
@yongholeeme yongholeeme marked this pull request as ready for review March 13, 2025 06:23
@yongholeeme yongholeeme requested a review from a team as a code owner March 13, 2025 06:23
@yongholeeme yongholeeme marked this pull request as draft March 13, 2025 06:23
@yongholeeme yongholeeme force-pushed the feature/97_peerDepsInDevDeps branch from a7c3ca5 to 15b9ed0 Compare March 13, 2025 06:24
@yceffort-naver
Copy link
Contributor

https://www.npmjs.com/package/jsonc-eslint-parser 이게 있어야할줄 알았는데 없어도 되네요?!

@yongholeeme
Copy link
Contributor Author

https://www.npmjs.com/package/jsonc-eslint-parser 이게 있어야할줄 알았는데 없어도 되네요?!

@yceffort-naver 님, 지금은 packageJson config 이 있어서 동작하는데, 단독으로 쓰려면 말씀주신 것처럼 파서가 있어야겠네요.

@yongholeeme yongholeeme force-pushed the feature/97_peerDepsInDevDeps branch from 2ca9e91 to 6882355 Compare March 13, 2025 07:58
@yongholeeme yongholeeme force-pushed the feature/97_peerDepsInDevDeps branch from 6882355 to ed4e86a Compare March 13, 2025 07:58
@yongholeeme yongholeeme marked this pull request as ready for review March 17, 2025 01:55
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

규칙 덕분에 저희 것도 고쳤군요 ㅋㅋ 감사합니다!

Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고고~

Copy link
Contributor

@byhhh2 byhhh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~ 감사합니다 👍

@yongholeeme yongholeeme merged commit 9b92992 into main Mar 31, 2025
3 checks passed
@yongholeeme yongholeeme deleted the feature/97_peerDepsInDevDeps branch March 31, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants