Skip to content

[eslint-config] Add new plugins#66

Merged
yongholeeme merged 9 commits intoeslint9from
feature/58_new
Dec 17, 2024
Merged

[eslint-config] Add new plugins#66
yongholeeme merged 9 commits intoeslint9from
feature/58_new

Conversation

@yongholeeme
Copy link
Contributor

@yongholeeme yongholeeme commented Dec 10, 2024

Related Issue

close #58

Describe your changes

@yongholeeme yongholeeme self-assigned this Dec 10, 2024
@yongholeeme yongholeeme requested a review from a team as a code owner December 10, 2024 09:39
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 525bca1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yongholeeme yongholeeme marked this pull request as draft December 10, 2024 09:47
@yongholeeme yongholeeme force-pushed the feature/58_new branch 4 times, most recently from 4e19310 to f172545 Compare December 11, 2024 09:23
@yongholeeme yongholeeme marked this pull request as ready for review December 11, 2024 09:23
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋다 좋다~~

@yongholeeme yongholeeme marked this pull request as draft December 11, 2024 10:52
Copy link
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

룰 업뎃 감사드립니다 :D 👍

Base automatically changed from feature/62_architecture to eslint9 December 17, 2024 01:49
@yongholeeme yongholeeme marked this pull request as ready for review December 17, 2024 07:53
Comment on lines +25 to +34
/**
* Disable rules that cause problems with YAML files requiring type information
*/
{
files: ['**/*.yaml', '**/*.yml'],
rules: {
'@typescript-eslint/naming-convention': 'off',
'@typescript-eslint/consistent-type-imports': 'off',
},
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 때문이었나요 ㅋㅋㅋ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dㅣ거 조금 걱정인데요, 저희 config 사용하면서 @typescript-eslint 룰 중에 타입 체킹관련 룰 추가하면 저 설정 추가해줘야하는데 관련 내용을 명시해줘야겠죠?;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning 은 써줘야할듯.. README에

Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다

@yongholeeme yongholeeme merged commit 03d4218 into eslint9 Dec 17, 2024
4 checks passed
@yongholeeme yongholeeme deleted the feature/58_new branch December 17, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants