Add ESLint rule ensuring peerDependencies are also declared in devDependencies#90
Merged
yceffort-naver merged 2 commits intomainfrom Feb 27, 2025
Merged
Add ESLint rule ensuring peerDependencies are also declared in devDependencies#90yceffort-naver merged 2 commits intomainfrom
yceffort-naver merged 2 commits intomainfrom
Conversation
Contributor
✅ Changeset detectedLatest commit: 5ba84c5
If no version change is needed, please add The changes in this PR will be included in the next version bump. powered by: naverpay changeset detect-add actions |
yujeong-jeon
approved these changes
Feb 27, 2025
Contributor
yujeong-jeon
left a comment
There was a problem hiding this comment.
감사합니다~! 현재 변경이 #82 (comment) 에서 말씀드린 바대로 에러만 Report하는 형태일것 같습니다
Contributor
Author
|
@yujeong-jeon 이게 버전 까지 지정해줘야 되서 fixable 로 해야할지 고민이 좀 되더라구요. 지금 그대로는 어떠세요? |
Contributor
아 네네 저도 auto-fix는 미지원해도 될거 같았습니다 :) 린트 검사만 터지는게 나을것 같습니다 |
Contributor
Author
|
꼬꼬 감사합니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this resolves #82
This pull request adds a new ESLint rule that validates the project's
package.jsonto ensure that all dependencies under "peerDependencies" are also declared in "devDependencies". This is important for local development because peer dependencies often need to be present in the developer's environment for builds, tests, and other tooling to work properly.Implementation Details
package.json.package.jsonas JSON and compares the keys inpeerDependenciesagainst those indevDependencies.devDependencies, an ESLint error is reported for each missing package.