Skip to content

code-style을 pite로 빌드합니다 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keemhyunseok merged 6 commits into from
Mar 11, 2025
Merged

code-style을 pite로 빌드합니다 #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94cae79
[#94] pite, vite 설치
keemhyunseok Feb 28, 2025
c93c85a
[#94] eslint-config pite build
keemhyunseok Feb 28, 2025
5f6bbf0
[#94] eslint-plugin pite 적용
keemhyunseok Feb 28, 2025
9a65beb
[#94] rollup 제거
keemhyunseok Feb 28, 2025
c43a164
Create curvy-suits-grow.md
keemhyunseok Feb 28, 2025
eec954e
[#94] 기본 cwd 사용
keemhyunseok Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/curvy-suits-grow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@naverpay/eslint-config": patch
"@naverpay/eslint-plugin": patch
---

code-style을 pite로 빌드합니다

PR: [code-style을 pite로 빌드합니다](https://github.com/NaverPayDev/code-style/pull/96)
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,14 @@
"@changesets/cli": "^2.26.2",
"@naverpay/eslint-config": "workspace:*",
"@naverpay/markdown-lint": "workspace:*",
"@naverpay/pite": "1.1.2",
"@naverpay/prettier-config": "workspace:*",
"@naverpay/stylelint-config": "workspace:*",
"lefthook": "^1.9.3",
"prettier": "^3.2.5",
"turbo": "^2.3.3",
"typescript": "^5.2.2"
"typescript": "^5.2.2",
"vite": "^6.2.0"
},
"packageManager": "pnpm@9.1.3",
"engines": {
Expand Down
9 changes: 4 additions & 5 deletions packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,24 @@
"name": "@naverpay/eslint-config",
"version": "2.2.2",
"description": "eslint config for naverpay",
"type": "module",
"main": "./dist/cjs/index.js",
"module": "./dist/esm/index.mjs",
"exports": {
".": {
"import": "./dist/esm/index.mjs",
"require": "./dist/cjs/index.js",
"default": "./dist/cjs/index.js"
}
},
"./package.json": "./package.json"
},
"sideEffects": false,
"files": [
"dist"
],
"scripts": {
"clean": "rm -rf dist",
"prebuild": "pnpm run clean",
"build": "rollup -c",
"build": "vite build",
"test": "vitest run",
"test:watch": "vitest watch"
},
Expand Down Expand Up @@ -56,10 +57,8 @@
"typescript-eslint": "^8.18.0"
},
"devDependencies": {
"@rollup/plugin-json": "^6.1.0",
"builtin-modules": "^4.0.0",
"eslint": "^9.17.0",
"rollup": "^4.27.4",
"vitest": "^2.1.5"
},
"peerDependencies": {
Expand Down
33 changes: 0 additions & 33 deletions packages/eslint-config/rollup.config.js
View file
Open in desktop

This file was deleted.

12 changes: 12 additions & 0 deletions packages/eslint-config/vite.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import {createViteConfig} from '@naverpay/pite'
import builtins from 'builtin-modules'

export default createViteConfig({
entry: ['./index.js'],
options: {
minify: false,
rollupOptions: {
external: [...builtins],
Copy link
Member

@2-one-week 2-one-week Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 이거 builtin 기본적으로 빠지게 설정 안했었나.. 기억이 안나네요

Copy link
Contributor Author

@keemhyunseok keemhyunseok Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 그런줄 알았는데 deps, peerDeps만 기본 external 처리되어 있습니다

Copy link
Contributor

@yceffort-naver yceffort-naver Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기본값으로 이거 빼는게 맞을거같네용..

Copy link
Contributor Author

@keemhyunseok keemhyunseok Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음버전에 반영하겠습니닷

},
},
})
19 changes: 9 additions & 10 deletions packages/eslint-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,24 @@
"name": "@naverpay/eslint-plugin",
"version": "2.1.0",
"description": "eslint plugin for naverpay",
"type": "module",
"main": "./dist/cjs/index.js",
"module": "./dist/esm/index.mjs",
"main": "./dist/cjs/lib/index.js",
"module": "./dist/esm/lib/index.mjs",
"sideEffects": false,
"exports": {
".": {
"import": "./dist/esm/index.mjs",
"require": "./dist/cjs/index.js",
"default": "./dist/cjs/index.js"
}
"import": "./dist/esm/lib/index.mjs",
"require": "./dist/cjs/lib/index.js",
"default": "./dist/cjs/lib/index.js"
},
"./package.json": "./package.json"
},
"files": [
"dist"
],
"scripts": {
"clean": "rm -rf dist",
"prebuild": "pnpm run clean",
"build": "rollup -c",
"build": "vite build",
"test": "vitest run",
"test:watch": "vitest watch"
},
Expand All @@ -45,10 +46,8 @@
"devDependencies": {
"@babel/eslint-parser": "^7.25.9",
"@babel/preset-react": "^7.24.7",
"@rollup/plugin-json": "^6.1.0",
"@typescript-eslint/parser": "^8.15.0",
"builtin-modules": "^4.0.0",
"rollup": "^4.27.4",
"vitest": "^2.1.5"
},
"peerDependencies": {
Expand Down
33 changes: 0 additions & 33 deletions packages/eslint-plugin/rollup.config.js
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions packages/eslint-plugin/vite.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import {createViteConfig} from '@naverpay/pite'
import builtins from 'builtin-modules'

export default createViteConfig({
entry: ['./lib/index.js'],
ignoredPolyfills: ['esnext.json.parse', 'es.array.push'],
Copy link
Contributor Author

@keemhyunseok keemhyunseok Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요것두 폴리필 불필요할 듯 하여 ignore처리했는데 혹시 최신 스펙 사용을 의도한 것이라면 말씀 부탁드립니닷,,

Copy link
Member

@2-one-week 2-one-week Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저거 두개 다 아마 ignore 처리해도 될 거에요

문서는 못찾겠는데 사소한 이슈로 알고 있습니다

Copy link
Contributor Author

@keemhyunseok keemhyunseok Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 코드로 보기에는 진짜 단순 parse, push만 쓴느 것 같아서 ignore할게용

options: {
minify: false,
rollupOptions: {
external: [...builtins],
},
},
})
Loading