Skip to content

같은 pdf 페이지 리렌더링시 발생하는 에러를 catch처리#191

Merged
2-one-week merged 2 commits intomainfrom
repo/190
Nov 21, 2025
Merged

같은 pdf 페이지 리렌더링시 발생하는 에러를 catch처리#191
2-one-week merged 2 commits intomainfrom
repo/190

Conversation

@keemhyunseok
Copy link
Contributor

@keemhyunseok keemhyunseok commented Jul 29, 2025

Related Issue

Describe your changes

  • 같은 pdf페이지가 리렌더링되면 RenderingCancelledException 에러 발생
  • ref를 통해 현재 렌더링되고 있는 id를 저장해 식별
  • pageRenderTask에 발생한 에러가 이전 렌더링 시기에 발생했다면 무시하도록 처리
  • 마지막에 발생한 렌더링에 대해서만 에러를 throw하도록 수정

Request

@keemhyunseok keemhyunseok self-assigned this Jul 29, 2025
@npayfebot
Copy link
Collaborator

npayfebot commented Jul 29, 2025

✅ Changeset detected

Latest commit: f64ab4f

@naverpay/react-pdf package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@naverpay/react-pdf 🐛 Patch
powered by: naverpay changeset detect-add actions

@npayfebot
Copy link
Collaborator

npayfebot commented Jul 29, 2025

NPM Packages

📦 @naverpay/react-pdf

Total Sizes: 22 kB

Total Changes: +147 B (+1%) (Size Increased)

File Status Previous Size Updated Size Changed
/dist/esm/components/page/Canvas.mjs 🛠️ 507 B 579 B +72 B (+14%)
/dist/cjs/components/page/Canvas.js 🛠️ 570 B 645 B +75 B (+13%)
ℹ️ View Unchanged Files
File Status Previous Size Updated Size Changed
/dist/esm/index.mjs - 310 B 310 B -
/dist/esm/utils/text.mjs - 567 B 567 B -
/dist/esm/utils/pdf.mjs - 1.21 kB 1.21 kB -
/dist/esm/utils/link-service.mjs - 843 B 843 B -
/dist/esm/utils/debounce.mjs - 148 B 148 B -
/dist/esm/hooks/usePdfViewerPageWidth.mjs - 439 B 439 B -
/dist/esm/hooks/useIsomorphicLayoutEffect.mjs - 136 B 136 B -
/dist/esm/hooks/useInfiniteScroll.mjs - 303 B 303 B -
/dist/esm/contexts/pdf.mjs - 308 B 308 B -
/dist/esm/contexts/page.mjs - 447 B 447 B -
/dist/esm/components/PdfViewer.module.mjs - 116 B 116 B -
/dist/esm/components/PdfViewer.mjs - 1.25 kB 1.25 kB -
/dist/esm/components/Pages.mjs - 902 B 902 B -
/dist/esm/components/layer/Text.module.mjs - 108 B 108 B -
/dist/esm/components/layer/Text.mjs - 1.25 kB 1.25 kB -
/dist/esm/components/layer/Annotation.module.mjs - 505 B 505 B -
/dist/esm/components/layer/Annotation.mjs - 1.01 kB 1.01 kB -
/dist/cjs/index.js - 406 B 406 B -
/dist/cjs/utils/text.js - 630 B 630 B -
/dist/cjs/utils/pdf.js - 1.28 kB 1.28 kB -
/dist/cjs/utils/link-service.js - 845 B 845 B -
/dist/cjs/utils/debounce.js - 211 B 211 B -
/dist/cjs/hooks/usePdfViewerPageWidth.js - 440 B 440 B -
/dist/cjs/hooks/useIsomorphicLayoutEffect.js - 192 B 192 B -
/dist/cjs/hooks/useInfiniteScroll.js - 300 B 300 B -
/dist/cjs/contexts/pdf.js - 375 B 375 B -
/dist/cjs/contexts/page.js - 516 B 516 B -
/dist/cjs/components/PdfViewer.module.js - 206 B 206 B -
/dist/cjs/components/PdfViewer.js - 1.31 kB 1.31 kB -
/dist/cjs/components/Pages.js - 978 B 978 B -
/dist/cjs/components/layer/Text.module.js - 118 B 118 B -
/dist/cjs/components/layer/Text.js - 1.33 kB 1.33 kB -
/dist/cjs/components/layer/Annotation.module.js - 673 B 673 B -
/dist/cjs/components/layer/Annotation.js - 1.08 kB 1.08 kB -

powered by: naverpay size-action

@keemhyunseok
Copy link
Contributor Author

/canary-publish

@npayfebot
Copy link
Collaborator

Published Canary Packages

@naverpay/react-pdf@2.0.0-canary.250729-0d8ecc1

@keemhyunseok
Copy link
Contributor Author

/canary-publish

@npayfebot
Copy link
Collaborator

Published Canary Packages

@naverpay/react-pdf@1.1.1-canary.250729-6726c65

@keemhyunseok keemhyunseok changed the title pdfjs-dist의 버전을 최신화합니다 같은 pdf 페이지 리렌더링시 발생하는 에러를 catch처리 Jul 29, 2025
@2-one-week 2-one-week marked this pull request as ready for review November 21, 2025 04:57
@2-one-week 2-one-week requested a review from a team as a code owner November 21, 2025 04:57
Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레츠고

@2-one-week 2-one-week merged commit 81d721a into main Nov 21, 2025
7 checks passed
@2-one-week 2-one-week deleted the repo/190 branch November 21, 2025 04:57
@keemhyunseok
Copy link
Contributor Author

어 뭐야 이거 정식 배포를 안했었꾼요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments