Skip to content

refactor: consolidate workflows into publish.yaml for npm OIDC#201

Merged
yceffort-naver merged 2 commits intomainfrom
oidc
Nov 18, 2025
Merged

refactor: consolidate workflows into publish.yaml for npm OIDC#201
yceffort-naver merged 2 commits intomainfrom
oidc

Conversation

@yceffort-naver
Copy link
Contributor

Related Issue

Describe your changes

Request

@yceffort-naver yceffort-naver self-assigned this Nov 17, 2025
@yceffort-naver yceffort-naver requested a review from a team as a code owner November 17, 2025 23:45
@npayfebot
Copy link
Collaborator

npayfebot commented Nov 17, 2025

🔍 No files have been changed

Latest commit: 3bbd87f

Please check your commit.

powered by: naverpay size-action

yujeong-jeon
yujeong-jeon previously approved these changes Nov 18, 2025
Copy link
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

Comment on lines +53 to +59
- name: Check and upgrade npm
run: |
echo "Current npm version:"
npm --version
npm install -g npm@latest
echo "Upgraded npm version:"
npm --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to add this step in device-info 😮 !! (minimum npm@11.5.1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I was using Node 22, I naturally assumed it would come with npm 11… I ended up wasting way too much time because of this. lol

@yujeong-jeon
Copy link
Contributor

yujeong-jeon commented Nov 18, 2025

We have to check repository field in each package.json.

npm error 422 Unprocessable Entity - PUT https://registry.npmjs.org/... - Error verifying sigstore provenance bundle:
 Failed to validate repository information: package.json: "repository.url" is "", expected to match 
"https://github.com/yujeongJeon/,,," from provenance

Co-authored-by: yujeong-jeon <148525642+yujeong-jeon@users.noreply.github.com>
@yceffort-naver
Copy link
Contributor Author

We have to check repository field in each package.json.

npm error 422 Unprocessable Entity - PUT https://registry.npmjs.org/... - Error verifying sigstore provenance bundle:
 Failed to validate repository information: package.json: "repository.url" is "", expected to match 
"https://github.com/yujeongJeon/,,," from provenance

Oh, so this field has become a required value as well. Thank you for checking it.

@yceffort-naver yceffort-naver merged commit 3d967c5 into main Nov 18, 2025
7 checks passed
@yceffort-naver yceffort-naver deleted the oidc branch November 18, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments