Skip to content

Comments

[공통] visualize 정상화 및 css 옵션 추가#68

Closed
2-one-week wants to merge 4 commits intomainfrom
repo/64_scss_export
Closed

[공통] visualize 정상화 및 css 옵션 추가#68
2-one-week wants to merge 4 commits intomainfrom
repo/64_scss_export

Conversation

@2-one-week
Copy link
Member

@2-one-week 2-one-week commented Mar 5, 2025 •
edited
Loading

Related Issue

Describe your changes

  • visualize가 제대로 동작하지 않아 이를 수정하고, option을 다양하게 받을 수 있도록 수정합니다.
  • css 관련 옵션을 추가해서, scss / css module / css extract 관련 대응을 합니다.
    • @keemhyunseok 님, 이렇게 진행해봤는데, 어떠신가요?

Request

@npayfebot
Copy link
Contributor

npayfebot commented Mar 5, 2025 •
edited
Loading

✅ Changeset detected

Latest commit: e9b4789

@naverpay/pite package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

powered by: naverpay changeset detect-add actions

@2-one-week 2-one-week changed the title \' [공통] visualize 정상화 및 css 옵션 추가 Mar 5, 2025
@npayfebot
Copy link
Contributor

npayfebot commented Mar 5, 2025 •
edited
Loading

NPM Packages

📦 @naverpay/pite

Total Sizes: 9.54 kB

Total Changes: +322 B (+3%) (Size Increased)

File Status Previous Size Updated Size Changed
/dist/index.mjs 🛠️ 1.36 kB 1.52 kB +158 B (+12%)
/dist/index.js 🛠️ 1.44 kB 1.61 kB +164 B (+11%)
ℹ️ View Unchanged Files
File Status Previous Size Updated Size Changed
/dist/vite-tsup-plugin.mjs - 678 B 678 B -
/dist/vite-tsup-plugin.js - 681 B 681 B -
/dist/util.mjs - 295 B 295 B -
/dist/util.js - 352 B 352 B -
/dist/polyfill.mjs - 204 B 204 B -
/dist/polyfill.js - 269 B 269 B -
/dist/get-vite-entry.mjs - 637 B 637 B -
/dist/get-vite-entry.js - 695 B 695 B -
/dist/dependencies.mjs - 337 B 337 B -
/dist/dependencies.js - 389 B 389 B -
/dist/browserslist.mjs - 264 B 264 B -
/dist/browserslist.js - 323 B 323 B -
/dist/plugins/rollup-plugin-publint.mjs - 640 B 640 B -
/dist/plugins/rollup-plugin-publint.js - 643 B 643 B -

powered by: naverpay size-action

2-one-week
2-one-week commented Mar 5, 2025
View reviewed changes
src/index.ts
outputs?: {format: 'es' | 'cjs'; dist: string}[]
cssFileName?: string
visualize?: boolean
visualize?: boolean | PluginVisualizerOptions
Copy link
Member Author

@2-one-week 2-one-week Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visualize 관련 옵션 받을 수 있게 수정

2-one-week
2-one-week commented Mar 5, 2025
View reviewed changes
src/index.ts
allowedPolyfills?: string[]
ignoredPolyfills?: string[]
options?: BuildOptions
css?: false | {filename: string; extract?: boolean; minify?: boolean; modules?: boolean; scss?: boolean}
Copy link
Member Author

@2-one-week 2-one-week Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • css 관련 번들이 필요 없으면 false
  • 있으면 옵션 객체 주입 필요
    • filename : css extract 될 파일 이름
    • extract : ssr을 지원하는 패키지일 때 필요 / code split을 통해 별도 파일 제공
    • minify : css 파일 압축 시 필요
    • modules : css modules 사용시 필요
    • scss : scss 지원 시 필요

@keemhyunseok
Copy link
Contributor

keemhyunseok commented Mar 5, 2025

요거 혹시 테스트 해보셨나용?

@2-one-week
Copy link
Member Author

2-one-week commented Mar 5, 2025

그냥 현재 pite에 수정해서 테스트 해볼게영

@keemhyunseok
Copy link
Contributor

keemhyunseok commented Mar 5, 2025

이건.. 카나리 테스트 해봐야할 것 같습니다
저거 css가 js처럼 빌드되는 현상이 발생할 수 있어서..

@2-one-week 2-one-week marked this pull request as draft March 6, 2025 09:28
@2-one-week
Copy link
Member Author

2-one-week commented Mar 6, 2025

pnpm link로 로컬 테스트 중인데 이슈가 있어서 수정 후에 draft 풀겠습니다

@2-one-week
Copy link
Member Author

2-one-week commented Mar 7, 2025

아 이거 css false 처리해도 vite 내부에서 자동 처리해서 빼는 것 같네요..?

@2-one-week
Copy link
Member Author

2-one-week commented Mar 7, 2025

@yceffort-naver 님

이거 기존에 rollup bundler와 같이

  1. css 포함하는 빌드
  2. css extract 하는 빌드
  3. scss, css-module 지원

이렇게 지원하면 되는걸까요..?

@yceffort-naver
Copy link
Contributor

yceffort-naver commented Mar 7, 2025

네네. 남은 작업 한번 정리해서... 논의 해야할거같아요

  • 말씀하신 추가 플러그인 네이티브 지원 여부
  • 아직 vite 로 못넘어간 패키지 확인
  • 리드미 작업

@2-one-week @keemhyunseok @byhhh2

@2-one-week
Copy link
Member Author

2-one-week commented Mar 7, 2025

@yceffort-naver 님

리드미는 영화님이 작성해주셨습니다! #69

@keemhyunseok @byhhh2 님

담주에 회의 한번 하실까용

@byhhh2
Copy link
Contributor

byhhh2 commented Mar 7, 2025

@2-one-week 님, @yceffort-naver 님, @keemhyunseok 님
좋습니다~ 오늘 스터디 끝나고 잠시 논의 해보아도..?

@2-one-week
Copy link
Member Author

2-one-week commented Mar 11, 2025

다시 돌아오겠습니다

@2-one-week 2-one-week closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[공통] scss export 처리 여부

5 participants

@2-one-week @npayfebot @keemhyunseok @yceffort-naver @byhhh2