fix: standardize ShipmentStatus type usage across API and UI (#218)#239
Open
ahmedabbas52233-a11y wants to merge 1 commit into
Open
Conversation
…mr#218) - Fix corrupted StatusBadge.tsx (removed duplicate component) - Import ShipmentStatus from API layer (shipments.ts) instead of UI layer - Fix STATUS_MAP in shipmentApi.ts to use API enum values - Resolve App.tsx merge corruption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #218 — Standardizes ShipmentStatus type usage and resolves type conflicts between API and UI layers.
Changes
shipmentStatus.tsutilsShipmentStatusfrom API layer (shipments.ts) instead of UI layerSTATUS_MAPto use API enum values (CREATED,IN_TRANSIT, etc.)Testing
pnpm run devstarts successfullyhttp://localhost:5173/