feat: added support for hyperevm, starknet and abstract chains by frolvanya · Pull Request #248 · Near-One/bridge-sdk-rs

frolvanya · 2026-02-10T15:15:16Z

Copilot

Pull request overview

Adds Starknet and HyperEVM chain support to the bridge SDK/CLI by introducing a new Starknet bridge client and wiring Starknet/HyperEVM into existing omni-connector flows.

Changes:

Introduces a new starknet-bridge-client crate (builder, error types, RPC + tx submission, event parsing).
Extends OmniConnector and bridge-cli with Starknet deploy/init/finalize/is-finalised support.
Adds HyperEVM into several “EVM-like” paths (address handling, finality checks, CLI deploy flow) and updates workspace dependencies (omni-types rev bump, starknet crate).

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
bridge-sdk/connectors/omni-connector/src/omni_connector.rs	Adds Starknet client wiring + Starknet transfer/deploy/finality helpers; extends chain/address matching for Starknet/HyperEVM
bridge-sdk/connectors/omni-connector/Cargo.toml	Adds `starknet-bridge-client` + `starknet` deps
bridge-sdk/connectors/bridge-connector-common/src/result.rs	Maps `StarknetBridgeClientError` into `BridgeSdkError` variants
bridge-sdk/connectors/bridge-connector-common/Cargo.toml	Adds `starknet-bridge-client` dependency
bridge-sdk/bridge-clients/starknet-bridge-client/src/starknet_bridge_client.rs	Implements Starknet OmniBridge interactions (tx send/wait, calldata encoding, receipt event extraction)
bridge-sdk/bridge-clients/starknet-bridge-client/src/builder.rs	Adds a builder for Starknet RPC/account/contract config
bridge-sdk/bridge-clients/starknet-bridge-client/src/error.rs	Defines Starknet bridge client error model
bridge-sdk/bridge-clients/starknet-bridge-client/Cargo.toml	New crate manifest
bridge-sdk/bridge-clients/evm-bridge-client/src/evm_bridge_client.rs	Extends EVM omni-address conversion to accept HyperEVM, rejects Starknet addresses
bridge-cli/src/omni_connector_command.rs	Adds Starknet CLI subcommands and includes HyperEVM in some CLI routing
bridge-cli/src/main.rs	Adds Starknet config flags/env/default wiring
bridge-cli/src/defaults.rs	Adds Starknet RPC + chain-id defaults
bridge-cli/Cargo.toml	Adds `starknet-bridge-client` dependency
Cargo.toml	Adds new workspace member + workspace dep on `starknet`, bumps `omni-types` rev
Cargo.lock	Updates lockfile for new deps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bridge-sdk/connectors/omni-connector/src/omni_connector.rs

bridge-cli/src/omni_connector_command.rs

bridge-sdk/bridge-clients/starknet-bridge-client/src/starknet_bridge_client.rs

* feat: added support for abstract chain * chore: added `CLAUDE.md` and `AGENTS.md`

bridge-cli/src/defaults.rs

bridge-cli/src/main.rs

bridge-sdk/bridge-clients/starknet-bridge-client/src/builder.rs

bridge-sdk/bridge-clients/starknet-bridge-client/src/starknet_bridge_client.rs

olga24912 · 2026-03-11T18:27:32Z

bridge-sdk/connectors/omni-connector/src/omni_connector.rs

+        })?;
+
+        let evm_log = EvmLog {
+            removed: rpc_log.removed,


Should always be true

Why? I always tested with false

https://github.com/Near-One/omni-bridge/blob/9b172eac9c1144aa246458505cdc19bd5f190272/near/omni-prover/mpc-omni-prover/src/tests.rs#L48

Well… technically it could be false. But then it means a reorg happened and this event no longer exists. If that happens, it’s bad. I would check just in case that it is true.

It defaults to false:

Yes, when I say true, I mean false...

I see😅
Fixed in 878eddf

bridge-sdk/connectors/omni-connector/src/omni_connector.rs

kiseln · 2026-03-13T19:40:00Z

bridge-sdk/bridge-clients/starknet-bridge-client/src/starknet_bridge_client.rs

I would suggest to move encoding/conversion functions to a separate module

kiseln · 2026-03-13T19:42:04Z

bridge-sdk/bridge-clients/starknet-bridge-client/src/starknet_bridge_client.rs

+            }
+        }
+        Err(StarknetBridgeClientError::TransactionError(format!(
+            "Transaction {tx_hash:#066x} was not confirmed after {MAX_RETRIES} seconds"


Isn't it going to be 300 seconds? I think we should limit it by 30-60 seconds rather than number of retries

Fixed in c73d843

The error message is still wrong.

Fixed in ed7dde7

kiseln · 2026-03-13T19:46:47Z

bridge-sdk/bridge-clients/starknet-bridge-client/src/builder.rs

+
+        let provider = Arc::new(JsonRpcClient::new(HttpTransport::new(url)));
+
+        let account = if let (Some(pk), Some(addr)) = (self.private_key, self.account_address) {


Should we error if one of the fields is missing?

kiseln · 2026-03-13T19:54:48Z

CLAUDE.md

@copilot which parts of this file are useful and which are not?

kiseln · 2026-03-14T01:06:54Z

bridge-sdk/connectors/omni-connector/src/omni_connector.rs

+    /// The `proof_kind` selects which event to look for:
+    /// - `InitTransfer` for `fin_transfer`
+    /// - `DeployToken` for `bind_token`
+    pub async fn build_abs_mpc_sign_payload(


I wonder if this is better as a part of a bridge client. The logic is fully contained to a single chain with lots of chain-specific concepts. Finalities then could also be configured at a client level.

omni_connector can orchestrate by pulling this payload from a bridge client and passing to the prover.

kiseln · 2026-03-14T03:20:31Z

bridge-sdk/connectors/omni-connector/src/omni_connector.rs

                    .await
                    .map(|hash| hash.to_string())
            }
+            BindTokenArgs::BindTokenWithMpcProofTx {


Since we are matching by chain_kind do we need to have separate variants for different types of proofs or should we have a single BindTokenWithTx?

kiseln · 2026-03-14T03:21:37Z

bridge-sdk/connectors/omni-connector/src/omni_connector.rs

+                transaction_options,
+            } => {
+                let sign_payload = match chain_kind {
+                    ChainKind::Abs => {


Better would be to match on any EVM chain, not just Abstract

kiseln · 2026-03-14T03:25:59Z

bridge-sdk/connectors/omni-connector/src/omni_connector.rs

+                transaction_options,
+            } => {
+                let sign_payload = match chain_kind {
+                    ChainKind::Abs => {


This should be the variant for any EVM chain with ReadMPC

Copilot · 2026-03-14T03:36:31Z

@kiseln I've opened a new pull request, #251, to work on those changes. Once the pull request is ready, I'll request review from you.

frolvanya requested a review from Copilot February 10, 2026 15:16

Copilot started reviewing on behalf of frolvanya February 10, 2026 15:16 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

feat: added support for hyperevm and starknet chains

d53833e

frolvanya force-pushed the feat/hyperevm-and-starknet branch from dc7c5bc to d53833e Compare February 10, 2026 16:16

frolvanya added 3 commits February 12, 2026 21:39

feat: added tests

fbe29a9

fix: minor patches

340eb46

fix: removed useless clone

2a3cbd0

frolvanya requested a review from a team February 13, 2026 02:52

frolvanya marked this pull request as ready for review February 13, 2026 02:53

frolvanya and others added 2 commits February 13, 2026 15:56

fix: option serialization

bb81ff9

feat: added support for abstract chain (#249)

76faa5d

* feat: added support for abstract chain * chore: added `CLAUDE.md` and `AGENTS.md`

frolvanya changed the title ~~feat: added support for hyperevm and starknet chains~~ feat: added support for hyperevm, starknet and abstract chains Mar 10, 2026

feat: added fin transfer flow for strk/abs clients

472ad9c

olga24912 requested changes Mar 11, 2026

View reviewed changes

frolvanya added 4 commits March 11, 2026 15:00

feat: added bind with mpc proof and much more

3df1011

docs: added info about abs private key in readme

d58af38

chore: added info that starknet account id should match private key

83923e4

fix: native_token_fee -> native_fee

52de88c

frolvanya requested a review from olga24912 March 11, 2026 19:12

frolvanya added 5 commits March 11, 2026 18:13

chore: updated omni-types

8022e6c

chore: renamed hyper_evm -> hyperevm

55e7e28

feat: added ClaimFeeWithMpcProofTx

5b932ec

chore: increased wait time

87bce2f

feat: made mpc finalities configurable

89c4559

kiseln reviewed Mar 14, 2026

View reviewed changes

Copilot AI mentioned this pull request Mar 14, 2026

Evaluate CLAUDE.md content usefulness #251

Closed

frolvanya added 2 commits March 14, 2026 00:26

chore: hardcode evm_log.removed to false

878eddf

chore: decrease number of retries from 30 to 5

c73d843

chore: fixed error message after fail after retries

ed7dde7


		let provider = Arc::new(JsonRpcClient::new(HttpTransport::new(url)));

		let account = if let (Some(pk), Some(addr)) = (self.private_key, self.account_address) {

Conversation

frolvanya commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

frolvanya commented Feb 10, 2026 •

edited

Loading