Removes unused gravity generator#5226
Merged
MistakeNot4892 merged 2 commits intoNebulaSS13:devfrom Dec 30, 2025
Merged
Conversation
MistakeNot4892
previously approved these changes
Dec 29, 2025
Contributor
MistakeNot4892
left a comment
MistakeNot4892
left a comment
There was a problem hiding this comment.
I didn't even know we HAD a gravity generator. If this functionality is desirable it should be added to the intertial damper.
MistakeNot4892
added
the
needs rebase/retarget
out-of-phaze
force-pushed
the
codequality/no-gravgen
branch
from
bf46ac6 to
796eed7
Compare
MistakeNot4892
approved these changes
Dec 30, 2025
Contributor
MistakeNot4892
left a comment
MistakeNot4892
left a comment
There was a problem hiding this comment.
Conflict resolution
MistakeNot4892
removed
the
needs rebase/retarget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Split out of #5120.
The first commit improves the gravity generator's code quality.
The second commit removes the gravity generator.
This is supposedly done in two commits so that if someone wants to readd the gravity generator they can just revert the second one and get a version with better code quality, but in reality I just cleaned up the code before realizing it wasn't used and didn't want to waste my effort, so...
Why and what will this PR improve
Removes some unused, really janky code.
Authorship
Me