Update manifest.json to use website tag with correct link#17
Update manifest.json to use website tag with correct link#17take-a-CHANCE wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the manifest.json file by changing the 'homepage' key to 'website' and updating the repository URL to the NeptuneHub organization. The review feedback identifies a naming inconsistency between the repository name in the URL and the Go module name, suggesting that these should be aligned to improve project consistency and maintainability.
| "id": "audiomuseai", | ||
| "author": "AudioMuse", | ||
| "homepage": "https://github.com/yourusername/audiomuse-navidrome-plugin", | ||
| "website": "https://github.com/NeptuneHub/AudioMuse-AI-NV-plugin", |
There was a problem hiding this comment.
The repository name in the URL (AudioMuse-AI-NV-plugin) is inconsistent with the Go module name (audiomuse-navidrome-plugin) used in the main.go imports (line 13). While the URL correctly points to the repository, this naming discrepancy can lead to confusion for maintainers. Consider aligning the repository name, Go module name, and plugin ID for better consistency across the project.
Just a small fix to the manifest.json so the github link shows up on the plugins page so you can quickly navigate to see if there is a new version. Based this off of the default Apple Music plugin's manifest.json: https://github.com/navidrome/apple-music-plugin/blob/main/manifest.json