Skip to content

Update manifest.json to use website tag with correct link#17

Open
take-a-CHANCE wants to merge 1 commit into
NeptuneHub:mainfrom
take-a-CHANCE:main
Open

Update manifest.json to use website tag with correct link#17
take-a-CHANCE wants to merge 1 commit into
NeptuneHub:mainfrom
take-a-CHANCE:main

Conversation

@take-a-CHANCE
Copy link
Copy Markdown

Just a small fix to the manifest.json so the github link shows up on the plugins page so you can quickly navigate to see if there is a new version. Based this off of the default Apple Music plugin's manifest.json: https://github.com/navidrome/apple-music-plugin/blob/main/manifest.json

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the manifest.json file by changing the 'homepage' key to 'website' and updating the repository URL to the NeptuneHub organization. The review feedback identifies a naming inconsistency between the repository name in the URL and the Go module name, suggesting that these should be aligned to improve project consistency and maintainability.

Comment thread manifest.json
"id": "audiomuseai",
"author": "AudioMuse",
"homepage": "https://github.com/yourusername/audiomuse-navidrome-plugin",
"website": "https://github.com/NeptuneHub/AudioMuse-AI-NV-plugin",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository name in the URL (AudioMuse-AI-NV-plugin) is inconsistent with the Go module name (audiomuse-navidrome-plugin) used in the main.go imports (line 13). While the URL correctly points to the repository, this naming discrepancy can lead to confusion for maintainers. Consider aligning the repository name, Go module name, and plugin ID for better consistency across the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant