Skip to content

Added a setting for the new Masqurade feature into the role menu #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Spyro24 wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −0
Open

Added a setting for the new Masqurade feature into the role menu #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3652a4
Added a setting for the new Masqurade feature into the role menu
Spyro24 Jul 7, 2026
825b66b
added the masq tag
Spyro24 Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/chat-api/Bitwise.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,12 @@ export const ROLE_PERMISSIONS = {
bit: 256,
description: () => "Allow users to mention roles",
icon: "alternate_email"
},
MASQUERADE: {
name: () => "Masquerade",
bit: 512,
description: () => "Allow members to change name and avatar per-message",
//icon: "alternate_email" // We dont need curently a icon for that because a "normal" user cant use it
}
};

Expand Down
1 change: 1 addition & 0 deletions src/chat-api/RawData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export interface RawMessage {

buttons: RawMessageButton[];
roleMentions: RawServerRole[];
creatorOverrideId?: string | null;
webhookId?: string;
}

Expand Down
3 changes: 3 additions & 0 deletions src/components/message-pane/message-item/MessageItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,9 @@ const Details = (props: DetailsProps) => {
: t("message.badge.bot")}
</div>
</Show>
<Show when={!props.message.webhookId && props.message.creatorOverrideId}>
<div class={styles.ownerBadge}>masq</div>
</Show>
Comment on lines +339 to +341

@coderabbitai coderabbitai Bot Jul 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use the i18n translation function for the masq badge text.

All other badges in this component (owner, bot, webhook) use t("message.badge.*") for localization. The hardcoded "masq" string breaks this pattern and won't be translatable.

🌐 Proposed fix to use i18n 
       <Show when={!props.message.webhookId && props.message.creatorOverrideId}>
-        <div class={styles.ownerBadge}>masq</div>
+        <div class={styles.ownerBadge}>{t("message.badge.masq")}</div>
       </Show>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Show when={!props.message.webhookId && props.message.creatorOverrideId}>
<div class={styles.ownerBadge}>masq</div>
</Show>
<Show when={!props.message.webhookId && props.message.creatorOverrideId}>
<div class={styles.ownerBadge}>{t("message.badge.masq")}</div>
</Show>
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/message-pane/message-item/MessageItem.tsx` around lines 339 -
341, Update the ownerBadge content in MessageItem to use the component’s
existing i18n translation function with the appropriate message.badge
translation key instead of the hardcoded “masq” text, matching the localization
pattern used by the owner, bot, and webhook badges.

<div class={styles.date}>{formatTimestamp(props.message.createdAt)}</div>
<Show when={props.message.silent}>
<Tooltip tooltip="Silent" anchor="left">
Expand Down