Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision
Keep the shared adjacent-group BK=128/GPB=2 grouped MMA mechanism and retain the exact T=32 route for Q4/Q5 A16 Attention only. Restore GDN T=32 selection to the upstream K64 route. No runtime cache detector, autotuner, device whitelist, or permanent experiment switch is added.
Why GDN is not enabled
At T=32, Attention improves in both Op cache cases, while GDN improves cold but regresses warm:
Two same-protocol C8 blocks ran in reverse order, B/A/AG then AG/A/B. Every request completed 1024 tokens, batch stayed 8, and all six waves used the same request seeds. The table reports actual steady committed tokens and MTP work; no profiler was attached.
Mean throughput: B 404.6, A 407.6, AG 404.4 tok/s. AG versus A was -4.8% in block 1 and +3.5% in block 2. The sign flips. Rates also fall with wave position in both blocks (position means 422.7, 407.6, 386.3 tok/s). The small overall difference cannot isolate a GDN contribution, so GDN remains on K64. The earlier R8 B→AG +4.8% combined result is not used to justify retaining GDN.
C1/C4, prefill, and shared GPB=1 controls
Existing B/AG controls are reused: C4/T=16 stays on the old routes (baseline mean 327.1 tok/s; prior narrow AG mean 323.1), and the 2048-token prefill result is 3577.1 ± 53.9 vs 3580.3 ± 12.5 tok/s. The old B/AG C1 control was 154.0 vs 157.0 tok/s. A was not rerun at C1 because it does not select T=32. These are not new measurements of the A arm.
The existing full T=1..128 cold/warm curves and T=512/1024 points show no consistent GPB=1 regression. Isolated high warm medians at T=64/T=128 return near baseline in the other wave; the 512/1024 controls remain close. Raw CSVs are included in the review evidence.
Validation
PR #311 remains a draft. Do not merge automatically.