Add helper methods to the TypesafeConfigReader.#440
Open
gorzell wants to merge 4 commits intoNetflix:2.xfrom
Open
Add helper methods to the TypesafeConfigReader.#440gorzell wants to merge 4 commits intoNetflix:2.xfrom
gorzell wants to merge 4 commits intoNetflix:2.xfrom
Conversation
added 3 commits
February 2, 2016 12:59
…ng more flexible for minor releases.
Contributor
Author
|
@elandau can I get a review on this? |
Contributor
|
@gorzell Sorry for taking so long to look at this. Can you please fix the conflict and I'll go ahead and merge. |
…feLoaderHelpers # Conflicts: # archaius2-typesafe/build.gradle
Contributor
Author
|
@elandau I fixed the conflict, but something seems to have gone sideways with the build, even the stable/previously successful branches no longer build on my laptop or in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some helper methods and tests for them. There is probably a large issue around how to support this kind of thing in the interface, but I figure this was a good start.